• Maciej Suminski's avatar
    Removed D_PAD::SetNetname() function and D_PAD::m_Netname, D_PAD::m_ShortNetname fields. · 654e7e55
    Maciej Suminski authored
    D_PAD::GetNetname() and D_PAD::GetShortNetname() were moved to BOARD_CONNECTED_ITEM. Now they use the net name stored in NETINFO_ITEM.
    Moved some one-line functions from class_board_connected_item.cpp to class_board_connected_item.h.
    Added a copyright notice, moved Doxygen comments from class_board_connected_item.cpp to class_board_connected_item.h.
    
    I have some doubts if changes introduced pcbnew/dialogs/dialog_pad_properties.cpp do not break anything, but I could not find a test case that breaks the pcbnew.
    
    Performed tests:
    - changed pad's net name from empty to existent - ok, name was changed
    - changed pad's net name from empty to nonexistent - ok, error message is displayed, net name stays empty
    - changed pad's net name from existent to empty - ok, net name became empty
    - changed pad's net name from existent to nonexistent - ok, error message is displayed, net name is not changed
    - (re)reading netlists, including net changes - fine, changes are applied, but empty nets are still kept
    - loaded pcbnew/pcad2kicadpcb_plugin/examples/CK1202_V1.pcb to test P-CAD import plugin - ok, net names are correct
    - imported an Eagle 6.0 board (Arduino Uno; http://arduino.cc/en/uploads/Main/arduino_Uno_Rev3-02-TH.zip) then saved in .kicad_pcb format and reloaded - ok, net names are correct
    - saved demos/video/video.kicad_pcb in legacy format and then loaded it again - ok, net names are correct
    654e7e55
Name
Last commit
Last update
..
examples Loading commit data...
CMakeLists.txt Loading commit data...
pcad2kicad_common.cpp Loading commit data...
pcad2kicad_common.h Loading commit data...
pcad_plugin.cpp Loading commit data...
pcad_plugin.h Loading commit data...
pcb.cpp Loading commit data...
pcb.h Loading commit data...
pcb_arc.cpp Loading commit data...
pcb_arc.h Loading commit data...
pcb_callbacks.h Loading commit data...
pcb_component.cpp Loading commit data...
pcb_component.h Loading commit data...
pcb_copper_pour.cpp Loading commit data...
pcb_copper_pour.h Loading commit data...
pcb_cutout.cpp Loading commit data...
pcb_cutout.h Loading commit data...
pcb_keepout.cpp Loading commit data...
pcb_keepout.h Loading commit data...
pcb_line.cpp Loading commit data...
pcb_line.h Loading commit data...
pcb_module.cpp Loading commit data...
pcb_module.h Loading commit data...
pcb_net.cpp Loading commit data...
pcb_net.h Loading commit data...
pcb_pad.cpp Loading commit data...
pcb_pad.h Loading commit data...
pcb_pad_shape.cpp Loading commit data...
pcb_pad_shape.h Loading commit data...
pcb_plane.cpp Loading commit data...
pcb_plane.h Loading commit data...
pcb_polygon.cpp Loading commit data...
pcb_polygon.h Loading commit data...
pcb_text.cpp Loading commit data...
pcb_text.h Loading commit data...
pcb_via.cpp Loading commit data...
pcb_via.h Loading commit data...
pcb_via_shape.cpp Loading commit data...
pcb_via_shape.h Loading commit data...
s_expr_loader.cpp Loading commit data...
s_expr_loader.h Loading commit data...