drc dialog was not showing the Netclass non-editable field on large font...

drc dialog was not showing the Netclass non-editable field on large font systems.  remember last size and position

pcbnew/dialog_drc.cpp

@@ -13,6 +13,12 @@
 #include "wxPcbStruct.h"
 #include "class_board_design_settings.h"
 
+
+// dialog should remember its previous screen position and size
+wxPoint DIALOG_DRC_CONTROL::s_LastPos( -1, -1 );
+wxSize  DIALOG_DRC_CONTROL::s_LastSize;
+
+
 /* class DIALOG_DRC_CONTROL: a dialog to set DRC parameters (clearance, min cooper size)
  * and run DRC tests
  */
@@ -28,6 +34,12 @@ DIALOG_DRC_CONTROL::DIALOG_DRC_CONTROL( DRC* aTester, WinEDA_PcbFrame* parent )
     {
         GetSizer()->SetSizeHints( this );
     }
+
+    if( s_LastPos.x != -1 )
+    {
+        SetSize( s_LastSize );
+        SetPosition( s_LastPos );
+    }
 }
 
 
@@ -50,7 +62,10 @@ void DIALOG_DRC_CONTROL::InitValues()
     AddUnitSymbol( *m_TrackMinWidthTitle );
     AddUnitSymbol( *m_ViaMinTitle );
     AddUnitSymbol( *m_MicroViaMinTitle );
+
+    /* this looks terrible! does not fit into text field, do it in wxformbuilder instead
     m_SetClearance->SetValue( _("Netclasses values"));
+    */
 
     Layout();      // adding the units above expanded Clearance text, now resize.
 
@@ -252,6 +267,11 @@ void DIALOG_DRC_CONTROL::OnOkClick( wxCommandEvent& event )
 {
     SetReturnCode( wxID_OK );
     SetDrcParmeters( );
+
+    // Save the dialog's position before finishing
+    s_LastPos  = GetPosition();
+    s_LastSize = GetSize();
+
     m_tester->DestroyDialog( wxID_OK );
 }
 
@@ -263,6 +283,11 @@ void DIALOG_DRC_CONTROL::OnOkClick( wxCommandEvent& event )
 void DIALOG_DRC_CONTROL::OnCancelClick( wxCommandEvent& event )
 {
     SetReturnCode( wxID_CANCEL );
+
+    // Save the dialog's position before finishing
+    s_LastPos  = GetPosition();
+    s_LastSize = GetSize();
+
     m_tester->DestroyDialog( wxID_CANCEL );
 }
 

pcbnew/dialog_drc.h

@@ -40,9 +40,14 @@ class DIALOG_DRC_CONTROL: public DIALOG_DRC_CONTROL_BASE
 public:
     /// Constructors
     DIALOG_DRC_CONTROL( DRC* aTester, WinEDA_PcbFrame* parent );
-	~DIALOG_DRC_CONTROL(){};
+    ~DIALOG_DRC_CONTROL(){};
 
 private:
+
+    static wxSize		    s_LastSize;		        ///< last position and size
+    static wxPoint		    s_LastPos;
+
+
     /**
      * Function writeReport
      * outputs the MARKER items and unconnecte DRC_ITEMs with commentary to an

pcbnew/dialog_drc_base.h

-///////////////////////////////////////////////////////////////////////////
-// C++ code generated with wxFormBuilder (version Apr 16 2008)
-// http://www.wxformbuilder.org/
-//
-// PLEASE DO "NOT" EDIT THIS FILE!
-///////////////////////////////////////////////////////////////////////////
-
-#ifndef __dialog_drc_base__
-#define __dialog_drc_base__
-
-#include <wx/intl.h>
-
-class DRCLISTBOX;
-
-#include <wx/string.h>
-#include <wx/stattext.h>
-#include <wx/gdicmn.h>
-#include <wx/font.h>
-#include <wx/colour.h>
-#include <wx/settings.h>
-#include <wx/textctrl.h>
-#include <wx/sizer.h>
-#include <wx/checkbox.h>
-#include <wx/button.h>
-#include <wx/statbox.h>
-#include <wx/listbox.h>
-#include <wx/panel.h>
-#include <wx/bitmap.h>
-#include <wx/image.h>
-#include <wx/icon.h>
-#include <wx/notebook.h>
-#include <wx/dialog.h>
-
-///////////////////////////////////////////////////////////////////////////
-
-#define ID_CHECKBOX_RPT_FILE 1000
-#define ID_BUTTON_BROWSE_RPT_FILE 1001
-#define ID_STARTDRC 1002
-#define ID_LIST_UNCONNECTED 1003
-#define ID_DELETE_ALL 1004
-#define ID_NOTEBOOK1 1005
-#define ID_CLEARANCE_LIST 1006
-#define ID_UNCONNECTED_LIST 1007
-
-///////////////////////////////////////////////////////////////////////////////
-/// Class DIALOG_DRC_CONTROL_BASE
-///////////////////////////////////////////////////////////////////////////////
-class DIALOG_DRC_CONTROL_BASE : public wxDialog 
-{
-	private:
-	
-	protected:
-		wxStaticText* m_ClearanceTitle;
-		wxStaticText* m_ViaMinTitle;
-		wxStaticText* m_TrackMinWidthTitle;
-		wxStaticText* m_MicroViaMinTitle;
-		wxButton* m_BrowseButton;
-		wxStaticText* m_staticText6;
-		wxTextCtrl* m_Messages;
-		wxButton* m_buttonRunDRC;
-		wxButton* m_buttonListUnconnected;
-		wxButton* m_DeleteAllButton;
-		wxButton* m_DeleteCurrentMarkerButton;
-		wxStaticText* m_staticTextErrMsg;
-		wxNotebook* m_Notebook;
-		wxPanel* m_panelClearanceListBox;
-		wxPanel* m_panelUnconnectedBox;
-		wxStdDialogButtonSizer* m_sdbSizer1;
-		wxButton* m_sdbSizer1OK;
-		wxButton* m_sdbSizer1Cancel;
-		
-		// Virtual event handlers, overide them in your derived class
-		virtual void OnReportCheckBoxClicked( wxCommandEvent& event ){ event.Skip(); }
-		virtual void OnButtonBrowseRptFileClick( wxCommandEvent& event ){ event.Skip(); }
-		virtual void OnStartdrcClick( wxCommandEvent& event ){ event.Skip(); }
-		virtual void OnListUnconnectedClick( wxCommandEvent& event ){ event.Skip(); }
-		virtual void OnDeleteAllClick( wxCommandEvent& event ){ event.Skip(); }
-		virtual void OnDeleteOneClick( wxCommandEvent& event ){ event.Skip(); }
-		virtual void OnLeftDClickClearance( wxMouseEvent& event ){ event.Skip(); }
-		virtual void OnRightUpClearance( wxMouseEvent& event ){ event.Skip(); }
-		virtual void OnLeftDClickUnconnected( wxMouseEvent& event ){ event.Skip(); }
-		virtual void OnRightUpUnconnected( wxMouseEvent& event ){ event.Skip(); }
-		virtual void OnCancelClick( wxCommandEvent& event ){ event.Skip(); }
-		virtual void OnOkClick( wxCommandEvent& event ){ event.Skip(); }
-		
-	
-	public:
-		wxTextCtrl* m_SetClearance;
-		wxTextCtrl* m_SetViaMinSizeCtrl;
-		wxTextCtrl* m_SetTrackMinWidthCtrl;
-		wxTextCtrl* m_SetMicroViakMinSizeCtrl;
-		wxCheckBox* m_CreateRptCtrl;
-		wxTextCtrl* m_RptFilenameCtrl;
-		DRCLISTBOX* m_ClearanceListBox;
-		DRCLISTBOX* m_UnconnectedListBox;
-		DIALOG_DRC_CONTROL_BASE( wxWindow* parent, wxWindowID id = wxID_ANY, const wxString& title = _("DRC Control"), const wxPoint& pos = wxDefaultPosition, const wxSize& size = wxSize( 800,508 ), long style = wxDEFAULT_DIALOG_STYLE|wxRESIZE_BORDER );
-		~DIALOG_DRC_CONTROL_BASE();
-	
-};
-
-#endif //__dialog_drc_base__
+///////////////////////////////////////////////////////////////////////////
+// C++ code generated with wxFormBuilder (version Dec 29 2008)
+// http://www.wxformbuilder.org/
+//
+// PLEASE DO "NOT" EDIT THIS FILE!
+///////////////////////////////////////////////////////////////////////////
+
+#ifndef __dialog_drc_base__
+#define __dialog_drc_base__
+
+#include <wx/intl.h>
+
+class DRCLISTBOX;
+
+#include <wx/string.h>
+#include <wx/stattext.h>
+#include <wx/gdicmn.h>
+#include <wx/font.h>
+#include <wx/colour.h>
+#include <wx/settings.h>
+#include <wx/textctrl.h>
+#include <wx/sizer.h>
+#include <wx/checkbox.h>
+#include <wx/button.h>
+#include <wx/statbox.h>
+#include <wx/listbox.h>
+#include <wx/panel.h>
+#include <wx/bitmap.h>
+#include <wx/image.h>
+#include <wx/icon.h>
+#include <wx/notebook.h>
+#include <wx/dialog.h>
+
+///////////////////////////////////////////////////////////////////////////
+
+#define ID_CHECKBOX_RPT_FILE 1000
+#define ID_BUTTON_BROWSE_RPT_FILE 1001
+#define ID_STARTDRC 1002
+#define ID_LIST_UNCONNECTED 1003
+#define ID_DELETE_ALL 1004
+#define ID_NOTEBOOK1 1005
+#define ID_CLEARANCE_LIST 1006
+#define ID_UNCONNECTED_LIST 1007
+
+///////////////////////////////////////////////////////////////////////////////
+/// Class DIALOG_DRC_CONTROL_BASE
+///////////////////////////////////////////////////////////////////////////////
+class DIALOG_DRC_CONTROL_BASE : public wxDialog 
+{
+	private:
+	
+	protected:
+		wxStaticText* m_ClearanceTitle;
+		wxStaticText* m_TrackMinWidthTitle;
+		wxStaticText* m_ViaMinTitle;
+		wxStaticText* m_MicroViaMinTitle;
+		wxButton* m_BrowseButton;
+		wxStaticText* m_staticText6;
+		wxTextCtrl* m_Messages;
+		wxButton* m_buttonRunDRC;
+		wxButton* m_buttonListUnconnected;
+		wxButton* m_DeleteAllButton;
+		wxButton* m_DeleteCurrentMarkerButton;
+		wxStaticText* m_staticTextErrMsg;
+		wxNotebook* m_Notebook;
+		wxPanel* m_panelClearanceListBox;
+		wxPanel* m_panelUnconnectedBox;
+		wxStdDialogButtonSizer* m_sdbSizer1;
+		wxButton* m_sdbSizer1OK;
+		wxButton* m_sdbSizer1Cancel;
+		
+		// Virtual event handlers, overide them in your derived class
+		virtual void OnReportCheckBoxClicked( wxCommandEvent& event ){ event.Skip(); }
+		virtual void OnButtonBrowseRptFileClick( wxCommandEvent& event ){ event.Skip(); }
+		virtual void OnStartdrcClick( wxCommandEvent& event ){ event.Skip(); }
+		virtual void OnListUnconnectedClick( wxCommandEvent& event ){ event.Skip(); }
+		virtual void OnDeleteAllClick( wxCommandEvent& event ){ event.Skip(); }
+		virtual void OnDeleteOneClick( wxCommandEvent& event ){ event.Skip(); }
+		virtual void OnLeftDClickClearance( wxMouseEvent& event ){ event.Skip(); }
+		virtual void OnRightUpClearance( wxMouseEvent& event ){ event.Skip(); }
+		virtual void OnLeftDClickUnconnected( wxMouseEvent& event ){ event.Skip(); }
+		virtual void OnRightUpUnconnected( wxMouseEvent& event ){ event.Skip(); }
+		virtual void OnCancelClick( wxCommandEvent& event ){ event.Skip(); }
+		virtual void OnOkClick( wxCommandEvent& event ){ event.Skip(); }
+		
+	
+	public:
+		wxTextCtrl* m_SetClearance;
+		wxTextCtrl* m_SetTrackMinWidthCtrl;
+		wxTextCtrl* m_SetViaMinSizeCtrl;
+		wxTextCtrl* m_SetMicroViakMinSizeCtrl;
+		wxCheckBox* m_CreateRptCtrl;
+		wxTextCtrl* m_RptFilenameCtrl;
+		DRCLISTBOX* m_ClearanceListBox;
+		DRCLISTBOX* m_UnconnectedListBox;
+		DIALOG_DRC_CONTROL_BASE( wxWindow* parent, wxWindowID id = wxID_ANY, const wxString& title = _("DRC Control"), const wxPoint& pos = wxDefaultPosition, const wxSize& size = wxSize( -1,-1 ), long style = wxDEFAULT_DIALOG_STYLE|wxRESIZE_BORDER );
+		~DIALOG_DRC_CONTROL_BASE();
+	
+};
+
+#endif //__dialog_drc_base__