Commit f2edf02b authored by Wayne Stambaugh's avatar Wayne Stambaugh
Browse files

Coverity error fixes. 

* Fix unitialized variable in MSG_PANEL_ITEM default ctor.
* Fix a bunch of uncaught exception issues.
* Fix a memory leak in the NETLIST_READER::GetNetlistReader() when an
  an attempt to read an invalid net list file occurs.
parent b0ad779e

include/msgpanel.h

+2 −1
Original line number Diff line number Diff line
@@ -71,7 +71,8 @@ public: 
    {

    }



    MSG_PANEL_ITEM()

    MSG_PANEL_ITEM() :

        m_Pad( MSG_PANEL_DEFAULT_PAD )

    {

    }

pcbnew/github/github_plugin.cpp

+1 −1
Original line number Diff line number Diff line
@@ -379,7 +379,7 @@ void GITHUB_PLUGIN::FootprintLibOptions( PROPERTIES* aListToAppendTo ) const 
}





void GITHUB_PLUGIN::cacheLib( const wxString& aLibraryPath, const PROPERTIES* aProperties ) throw( IO_ERROR )

void GITHUB_PLUGIN::cacheLib( const wxString& aLibraryPath, const PROPERTIES* aProperties )

{

    // This is edge triggered based on a change in 'aLibraryPath',

    // usually it does nothing.  When the edge fires, m_pretty_dir is set

pcbnew/github/github_plugin.h

+1 −1
Original line number Diff line number Diff line
@@ -200,7 +200,7 @@ protected: 


    void init( const PROPERTIES* aProperties );



    void cacheLib( const wxString& aLibraryPath, const PROPERTIES* aProperties ) throw( IO_ERROR );

    void cacheLib( const wxString& aLibraryPath, const PROPERTIES* aProperties );



    /**

     * Function repoURL_zipURL

pcbnew/netlist_reader.cpp

+1 −1
Original line number Diff line number Diff line
@@ -126,9 +126,9 @@ NETLIST_READER* NETLIST_READER::GetNetlistReader( NETLIST* aNetlist, 


    default:    // Unrecognized format:

        break;



    }



    delete cmpFileReader;

    return NULL;

}

pcbnew/specctra.cpp

+11 −10
Original line number Diff line number Diff line
@@ -602,7 +602,8 @@ void SPECCTRA_DB::doLAYER_PAIR( LAYER_PAIR* growth ) throw( IO_ERROR ) 
}





void SPECCTRA_DB::doLAYER_NOISE_WEIGHT( LAYER_NOISE_WEIGHT* growth ) throw( IO_ERROR )

void SPECCTRA_DB::doLAYER_NOISE_WEIGHT( LAYER_NOISE_WEIGHT* growth )

    throw( IO_ERROR, boost::bad_pointer )

{

    T       tok;
@@ -755,7 +756,7 @@ L_place: 
}





void SPECCTRA_DB::doSTRUCTURE_OUT( STRUCTURE_OUT* growth ) throw( IO_ERROR )

void SPECCTRA_DB::doSTRUCTURE_OUT( STRUCTURE_OUT* growth ) throw( IO_ERROR, boost::bad_pointer )

{

    /*

    <structure_out_descriptor >::=
@@ -1862,7 +1863,7 @@ void SPECCTRA_DB::doPLACE( PLACE* growth ) throw( IO_ERROR ) 
}





void SPECCTRA_DB::doCOMPONENT( COMPONENT* growth ) throw( IO_ERROR )

void SPECCTRA_DB::doCOMPONENT( COMPONENT* growth ) throw( IO_ERROR, boost::bad_pointer )

{

    T       tok = NextTok();
@@ -2130,7 +2131,7 @@ L_done_that: 
}





void SPECCTRA_DB::doIMAGE( IMAGE* growth ) throw( IO_ERROR )

void SPECCTRA_DB::doIMAGE( IMAGE* growth ) throw( IO_ERROR, boost::bad_pointer )

{

    T       tok = NextTok();
@@ -2327,7 +2328,7 @@ void SPECCTRA_DB::doLIBRARY( LIBRARY* growth ) throw( IO_ERROR ) 
}





void SPECCTRA_DB::doNET( NET* growth ) throw( IO_ERROR )

void SPECCTRA_DB::doNET( NET* growth ) throw( IO_ERROR, boost::bad_pointer )

{

    T           tok = NextTok();

    PIN_REFS*   pin_refs;
@@ -2615,7 +2616,7 @@ void SPECCTRA_DB::doCLASS( CLASS* growth ) throw( IO_ERROR ) 
}





void SPECCTRA_DB::doNETWORK( NETWORK* growth ) throw( IO_ERROR )

void SPECCTRA_DB::doNETWORK( NETWORK* growth ) throw( IO_ERROR, boost::bad_pointer )

{

    T       tok;
@@ -2764,7 +2765,7 @@ void SPECCTRA_DB::doFROMTO( FROMTO* growth ) throw( IO_ERROR ) 
}





void SPECCTRA_DB::doWIRE( WIRE* growth ) throw( IO_ERROR )

void SPECCTRA_DB::doWIRE( WIRE* growth ) throw( IO_ERROR, boost::bad_pointer )

{

    T       tok;
@@ -3083,7 +3084,7 @@ void SPECCTRA_DB::doANCESTOR( ANCESTOR* growth ) throw( IO_ERROR ) 
}





void SPECCTRA_DB::doHISTORY( HISTORY* growth ) throw( IO_ERROR )

void SPECCTRA_DB::doHISTORY( HISTORY* growth ) throw( IO_ERROR, boost::bad_pointer )

{

    T       tok;
@@ -3257,7 +3258,7 @@ void SPECCTRA_DB::doWAS_IS( WAS_IS* growth ) throw( IO_ERROR ) 
}





void SPECCTRA_DB::doROUTE( ROUTE* growth ) throw( IO_ERROR )

void SPECCTRA_DB::doROUTE( ROUTE* growth ) throw( IO_ERROR, boost::bad_pointer )

{

    T       tok;
@@ -3340,7 +3341,7 @@ void SPECCTRA_DB::doROUTE( ROUTE* growth ) throw( IO_ERROR ) 
}





void SPECCTRA_DB::doNET_OUT( NET_OUT* growth ) throw( IO_ERROR )

void SPECCTRA_DB::doNET_OUT( NET_OUT* growth ) throw( IO_ERROR, boost::bad_pointer )

{

    T       tok;