better error reporting and parsing of bad legacy footprint libs

eeschema/dialogs/dialog_annotate.cpp

 /**
- * @file annotate_dialog.cpp
+ * @file dialog_annotate.cpp
  * @brief Annotation dialog functions.
  */
 

include/reporter.h

@@ -44,8 +44,8 @@ class wxTextCtrl;
  * The purpose of the REPORTER object is to offer a way for a procedural function
  * to report multiple errors without having to:
  * <ul>
- * <li> a) know too much about the caller's UI, i.e. wx. </li>
- * <li> b) stop after the first error </li>
+ * <li> know too much about the caller's UI, i.e. wx. </li>
+ * <li> stop after the first error </li>
  * </ul>
  */
 class REPORTER

kicad/dialogs/dialog_template_selector.h

@@ -25,17 +25,18 @@
 #ifndef PROJECT_TEMPLATE_SELECTOR_H
 #define PROJECT_TEMPLATE_SELECTOR_H
 
-#include "dialogs/dialog_template_selector_base.h"
+#include <dialogs/dialog_template_selector_base.h>
 #include "project_template.h"
 
+
 class TEMPLATE_WIDGET : public TEMPLATE_WIDGET_BASE
 {
 protected:
-    wxDialog* dialog;
-    wxWindow* parent;
-    wxPanel* panel;
+    wxDialog*   dialog;
+    wxWindow*   parent;
+    wxPanel*    panel;
+    bool        selected;
 
-    bool selected;
     PROJECT_TEMPLATE* templ;
 
     void OnKillFocus( wxFocusEvent& event );
@@ -56,6 +57,7 @@ public:
     bool IsSelected();
 };
 
+
 class TEMPLATE_SELECTION_PANEL : public TEMPLATE_SELECTION_PANEL_BASE
 {
 protected:
@@ -65,6 +67,7 @@ protected:
 public:
     /**
      * @param aParent The window creating the dialog
+     * @param aPath the path
      */
     TEMPLATE_SELECTION_PANEL( wxWindow* aParent, const wxString& aPath );
     ~TEMPLATE_SELECTION_PANEL();
@@ -72,6 +75,7 @@ public:
     const wxString& GetPath() { return m_templatesPath; }
 };
 
+
 class DIALOG_TEMPLATE_SELECTOR : public DIALOG_TEMPLATE_SELECTOR_BASE
 {
 protected:
@@ -92,7 +96,7 @@ public:
     TEMPLATE_WIDGET* GetWidget();
     void SetWidget( TEMPLATE_WIDGET* aWidget );
     void onNotebookResize( wxSizeEvent& event );
-	void OnPageChange( wxNotebookEvent& event );
+    void OnPageChange( wxNotebookEvent& event );
 };
 
 #endif

kicad/project_template.h

@@ -59,7 +59,7 @@
         ~~~~~~~~~~~~~~
 
         /info.html  - Contains html formatted information about the template which is used by the
-                      user to determine if the template is what they are after. The <title> tag
+                      user to determine if the template is what they are after. The &lt;title&gt; tag
                       determines the actual name of the template that is exposed to the user for
                       template selection. Using html to format this document means that images can
                       be in-lined without having to invent a new scheme. Only HTML supported by

pcbnew/legacy_plugin.h

@@ -106,7 +106,7 @@ public:
     void SetReader( LINE_READER* aReader )      { m_reader = aReader; }
     void SetFilePtr( FILE* aFile )              { m_fp = aFile; }
 
-    MODULE* LoadMODULE();
+    void    LoadMODULE( MODULE* aModule );
     void    SaveMODULE( const MODULE* aModule ) const;
     void    SaveModule3D( const MODULE* aModule ) const;
     void    SaveBOARD( const BOARD* aBoard ) const;