Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
K
kicad-source-mirror
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Commits
Open sidebar
Elphel
kicad-source-mirror
Commits
d696ee8c
Commit
d696ee8c
authored
Sep 28, 2010
by
jean-pierre charras
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Gerbview: added support og regular polygon aperure definition.
parent
6417db15
Changes
7
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
7 changed files
with
246 additions
and
166 deletions
+246
-166
CHANGELOG.txt
CHANGELOG.txt
+1
-2
class_gerber_draw_item.cpp
gerbview/class_gerber_draw_item.cpp
+5
-1
class_gerber_draw_item.h
gerbview/class_gerber_draw_item.h
+2
-1
dcode.cpp
gerbview/dcode.cpp
+113
-102
dcode.h
gerbview/dcode.h
+65
-48
rs274d.cpp
gerbview/rs274d.cpp
+3
-0
rs274x.cpp
gerbview/rs274x.cpp
+57
-12
No files found.
CHANGELOG.txt
View file @
d696ee8c
...
...
@@ -12,12 +12,11 @@ email address.
graphics items are now specific to gerbview (added a GERBER_DRAW_ITEM class)
and do not use tracks from pcbnew.
The way used to draw them is also new.
Apertures are now correctly drawn for round, oval
and rectangular
shapes
Apertures are now correctly drawn for round, oval
, rectangular and regular polygon
shapes
(with or without holes)
Aperture definition type Polygon is not yet handle.
Polygons are correctly drawn.
TODO:
Draw functions for aperture definition type Polygon.
Draw functions for aperture macros.
Work in progress.
...
...
gerbview/class_gerber_draw_item.cpp
View file @
d696ee8c
...
...
@@ -106,10 +106,13 @@ wxString GERBER_DRAW_ITEM::ShowGBRShape()
case
GBR_SPOT_RECT
:
return
wxT
(
"spot_rect"
);
case
GBR_SPOT_POLY
:
return
wxT
(
"spot_poly"
);
case
GBR_POLYGON
:
return
wxT
(
"polygon"
);
case
GBR_MACRO
:
case
GBR_
SPOT_
MACRO
:
return
wxT
(
"apt_macro"
);
// TODO: add aperture macro name
default
:
...
...
@@ -276,6 +279,7 @@ void GERBER_DRAW_ITEM::Draw( WinEDA_DrawPanel* panel, wxDC* DC, int draw_mode,
case
GBR_SPOT_CIRCLE
:
case
GBR_SPOT_RECT
:
case
GBR_SPOT_OVAL
:
case
GBR_SPOT_POLY
:
isFilled
=
DisplayOpt
.
DisplayPadFill
?
true
:
false
;
d_codeDescr
->
DrawFlashedShape
(
&
panel
->
m_ClipBox
,
DC
,
color
,
m_Start
,
isFilled
);
...
...
gerbview/class_gerber_draw_item.h
View file @
d696ee8c
...
...
@@ -40,7 +40,8 @@ enum Gbr_Basic_Shapes {
GBR_SPOT_CIRCLE
,
// flashed shape: round shape (can have hole)
GBR_SPOT_RECT
,
// flashed shape: rectangular shape can have hole)
GBR_SPOT_OVAL
,
// flashed shape: oval shape
GBR_MACRO
,
// complex shape described by a macro
GBR_SPOT_POLY
,
// flashed shape: regulat polygon, 3 to 12 edges
GBR_SPOT_MACRO
,
// complex shape described by a macro
GBR_LAST
// last value for this list
};
...
...
gerbview/dcode.cpp
View file @
d696ee8c
This diff is collapsed.
Click to expand it.
gerbview/dcode.h
View file @
d696ee8c
...
...
@@ -16,20 +16,30 @@
* is the set of all gerber aperture types allowed, according to page 16 of
* http://gerbv.sourceforge.net/docs/rs274xrevd_e.pdf
*/
enum
APERTURE_T
{
APT_CIRCLE
=
'C'
,
APT_LINE
=
'L'
,
APT_RECT
=
'R'
,
APT_OVAL
=
'0'
,
enum
APERTURE_T
{
APT_CIRCLE
=
'C'
,
APT_LINE
=
'L'
,
APT_RECT
=
'R'
,
APT_OVAL
=
'0'
,
APT_POLYGON
=
'P'
,
APT_MACRO
=
'M'
APT_MACRO
=
'M'
};
// In aperture definition, round, oval and rectangular flashed shapes
// can have a hole (ropund or rectangular)
// this option is stored in .m_DrillShape D_CODE member
enum
APERTURE_DEF_HOLETYPE
{
APT_DEF_NO_HOLE
=
0
,
APT_DEF_ROUND_HOLE
,
APT_DEF_RECT_HOLE
};
#define FIRST_DCODE 10
#define LAST_DCODE 999 // dcodes values are from 10 to 999
#define TOOLS_MAX_COUNT (LAST_DCODE+1)
/* define min and max values for D Codes values.
* note: values >= 0 and > FIRST_DCODE can be used for specila purposes
*/
#define FIRST_DCODE 10
#define LAST_DCODE 999
#define TOOLS_MAX_COUNT (LAST_DCODE + 1)
class
D_CODE
;
...
...
@@ -46,17 +56,19 @@ class DCODE_PARAM
{
public
:
DCODE_PARAM
()
:
index
(
-
1
),
value
(
0
.
0
)
index
(
-
1
),
value
(
0
.
0
)
{}
double
GetValue
(
const
D_CODE
*
aDcode
)
const
;
double
GetValue
(
const
D_CODE
*
aDcode
)
const
;
void
SetValue
(
double
aValue
)
{
value
=
aValue
;
index
=
-
1
;
}
/**
* Function IsImmediate
* tests if this DCODE_PARAM holds an immediate parameter or is a pointer
...
...
@@ -69,16 +81,18 @@ public:
return
(
unsigned
)
index
;
}
void
SetIndex
(
int
aIndex
)
{
index
=
aIndex
;
}
private
:
int
index
;
///< if -1, then \a value field is an immediate value,
int
index
;
///< if -1, then \a value field is an immediate value,
// else this is an index into parent's
// D_CODE.m_am_params.
double
value
;
///< if IsImmediate()==true then use the value, else
double
value
;
///< if IsImmediate()==true then use the value, else
// not used.
};
...
...
@@ -88,22 +102,21 @@ private:
* is the set of all "aperture macro primitives" (primitive numbers). See
* Table 3 in http://gerbv.sourceforge.net/docs/rs274xrevd_e.pdf
*/
enum
AM_PRIMITIVE_ID
{
AMP_CIRCLE
=
1
,
AMP_LINE2
=
2
,
enum
AM_PRIMITIVE_ID
{
AMP_CIRCLE
=
1
,
AMP_LINE2
=
2
,
AMP_LINE20
=
20
,
AMP_LINE_CENTER
=
21
,
AMP_LINE_LOWER_LEFT
=
22
,
AMP_EOF
=
3
,
AMP_EOF
=
3
,
AMP_OUTLINE
=
4
,
AMP_POLYGON
=
5
,
AMP_MOIRE
=
6
,
AMP_MOIRE
=
6
,
AMP_THERMAL
=
7
,
};
typedef
std
::
vector
<
DCODE_PARAM
>
DCODE_PARAMS
;
typedef
std
::
vector
<
DCODE_PARAM
>
DCODE_PARAMS
;
/**
* Struct AM_PRIMITIVE
...
...
@@ -112,8 +125,8 @@ typedef std::vector<DCODE_PARAM> DCODE_PARAMS;
*/
struct
AM_PRIMITIVE
{
AM_PRIMITIVE_ID
primitive_id
;
///< The primitive type
DCODE_PARAMS
params
;
///< A sequence of parameters used by
AM_PRIMITIVE_ID
primitive_id
;
///< The primitive type
DCODE_PARAMS
params
;
///< A sequence of parameters used by
// the primitive
/**
...
...
@@ -130,7 +143,7 @@ struct AM_PRIMITIVE
};
typedef
std
::
vector
<
AM_PRIMITIVE
>
AM_PRIMITIVES
;
typedef
std
::
vector
<
AM_PRIMITIVE
>
AM_PRIMITIVES
;
/**
* Struct APERTURE_MACRO
...
...
@@ -138,8 +151,8 @@ typedef std::vector<AM_PRIMITIVE> AM_PRIMITIVES;
*/
struct
APERTURE_MACRO
{
wxString
name
;
///< The name of the aperture macro
AM_PRIMITIVES
primitives
;
///< A sequence of AM_PRIMITIVEs
wxString
name
;
///< The name of the aperture macro
AM_PRIMITIVES
primitives
;
///< A sequence of AM_PRIMITIVEs
};
...
...
@@ -151,7 +164,7 @@ struct APERTURE_MACRO
struct
APERTURE_MACRO_less_than
{
// a "less than" test on two APERTURE_MACROs (.name wxStrings)
bool
operator
()(
const
APERTURE_MACRO
&
am1
,
const
APERTURE_MACRO
&
am2
)
const
bool
operator
()(
const
APERTURE_MACRO
&
am1
,
const
APERTURE_MACRO
&
am2
)
const
{
return
am1
.
name
.
Cmp
(
am2
.
name
)
<
0
;
// case specific wxString compare
}
...
...
@@ -163,8 +176,8 @@ struct APERTURE_MACRO_less_than
* is a sorted collection of APERTURE_MACROS whose key is the name field in
* the APERTURE_MACRO.
*/
typedef
std
::
set
<
APERTURE_MACRO
,
APERTURE_MACRO_less_than
>
APERTURE_MACRO_SET
;
typedef
std
::
pair
<
APERTURE_MACRO_SET
::
iterator
,
bool
>
APERTURE_MACRO_SET_PAIR
;
typedef
std
::
set
<
APERTURE_MACRO
,
APERTURE_MACRO_less_than
>
APERTURE_MACRO_SET
;
typedef
std
::
pair
<
APERTURE_MACRO_SET
::
iterator
,
bool
>
APERTURE_MACRO_SET_PAIR
;
/**
...
...
@@ -182,7 +195,7 @@ class D_CODE
* parameters used only when this D_CODE holds a reference to an aperture
* macro, and these parameters would customize the macro.
*/
DCODE_PARAMS
m_am_params
;
DCODE_PARAMS
m_am_params
;
std
::
vector
<
wxPoint
>
m_PolyCorners
;
/* Polygon used to draw AMP_POLYGON shape and some other
* complex shapes which are converted to polygon
...
...
@@ -190,15 +203,16 @@ class D_CODE
*/
public
:
wxSize
m_Size
;
/* Horizontal and vertical dimensions. */
APERTURE_T
m_Shape
;
/* shape ( Line, rectangle, circle , oval .. ) */
int
m_Num_Dcode
;
/* D code ( >= 10 ) */
wxSize
m_Drill
;
/* dimension of the hole (if any) */
int
m_DrillShape
;
/* shape of the hole (round = 1, rect = 2) */
double
m_Rotation
;
/* shape rotation in degrees */
bool
m_InUse
;
/* FALSE if not used */
bool
m_Defined
;
/* FALSE if not defined */
wxString
m_SpecialDescr
;
wxSize
m_Size
;
/* Horizontal and vertical dimensions. */
APERTURE_T
m_Shape
;
/* shape ( Line, rectangle, circle , oval .. ) */
int
m_Num_Dcode
;
/* D code ( >= 10 ) */
wxSize
m_Drill
;
/* dimension of the hole (if any) */
APERTURE_DEF_HOLETYPE
m_DrillShape
;
/* shape of the hole (0 = no hole, round = 1, rect = 2) */
double
m_Rotation
;
/* shape rotation in degrees */
int
m_EdgesCount
;
/* in apeture definition Polygon only: number of edges for the polygon */
bool
m_InUse
;
/* FALSE if not used */
bool
m_Defined
;
/* FALSE if not defined */
wxString
m_SpecialDescr
;
public
:
D_CODE
(
int
num_dcode
);
...
...
@@ -214,10 +228,13 @@ public:
m_am_params
.
push_back
(
param
);
}
void
SetMacro
(
APERTURE_MACRO
*
aMacro
)
{
m_Macro
=
aMacro
;
}
APERTURE_MACRO
*
GetMacro
()
{
return
m_Macro
;
}
/**
...
...
@@ -231,8 +248,8 @@ public:
* Draw the dcode shape for flashed items.
* When an item is flashed, the DCode shape is the shape of the item
*/
void
DrawFlashedShape
(
EDA_Rect
*
aClipBox
,
wxDC
*
aDC
,
int
aColor
,
wxPoint
aShapePos
,
bool
aFilledShape
);
void
DrawFlashedShape
(
EDA_Rect
*
aClipBox
,
wxDC
*
aDC
,
int
aColor
,
wxPoint
aShapePos
,
bool
aFilledShape
);
/** function DrawFlashedPolygon
* a helper function used id ::Draw to draw the polygon stored ion m_PolyCorners
...
...
@@ -240,8 +257,8 @@ public:
* APT_POLYGON is always a polygon, but some complex shapes are also converted to
* polygons (shapes with holes, some rotated shapes)
*/
void
DrawFlashedPolygon
(
EDA_Rect
*
aClipBox
,
wxDC
*
aDC
,
int
aColor
,
bool
aFilled
,
const
wxPoint
&
aPosition
);
void
DrawFlashedPolygon
(
EDA_Rect
*
aClipBox
,
wxDC
*
aDC
,
int
aColor
,
bool
aFilled
,
const
wxPoint
&
aPosition
);
/** function ConvertShapeToPolygon
* convert a shape to an equivalent polygon.
...
...
@@ -249,8 +266,7 @@ public:
* Useful when a shape is not a graphic primitive (shape with hole,
* rotated shape ... ) and cannot be easily drawn.
*/
void
ConvertShapeToPolygon
(
);
void
ConvertShapeToPolygon
();
};
...
...
@@ -262,13 +278,14 @@ inline double DCODE_PARAM::GetValue( const D_CODE* aDcode ) const
{
// the first one was numbered 1, not zero, as in $1, see page 19 of spec.
unsigned
ndx
=
GetIndex
()
-
1
;
wxASSERT
(
aDcode
);
wxASSERT
(
aDcode
);
// get the parameter from the aDcode
if
(
ndx
<
aDcode
->
m_am_params
.
size
()
)
return
aDcode
->
m_am_params
[
ndx
].
GetValue
(
NULL
);
else
{
wxASSERT
(
GetIndex
()
-
1
<
aDcode
->
m_am_params
.
size
()
);
wxASSERT
(
GetIndex
()
-
1
<
aDcode
->
m_am_params
.
size
()
);
return
0
.
0
;
}
}
...
...
gerbview/rs274d.cpp
View file @
d696ee8c
...
...
@@ -1095,6 +1095,7 @@ bool GERBER::Execute_DCODE_Command( WinEDA_GerberFrame* frame,
switch
(
aperture
)
{
case
APT_POLYGON
:
// flashed regular polygon
case
APT_CIRCLE
:
gbritem
=
new
GERBER_DRAW_ITEM
(
pcb
);
pcb
->
m_Drawings
.
Append
(
gbritem
);
...
...
@@ -1102,6 +1103,8 @@ bool GERBER::Execute_DCODE_Command( WinEDA_GerberFrame* frame,
fillRoundFlashGBRITEM
(
gbritem
,
dcode
,
activeLayer
,
m_CurrentPos
,
size
.
x
,
!
(
m_LayerNegative
^
m_ImageNegative
)
);
if
(
aperture
==
APT_POLYGON
)
gbritem
->
m_Shape
=
GBR_SPOT_POLY
;
break
;
case
APT_OVAL
:
...
...
gerbview/rs274x.cpp
View file @
d696ee8c
...
...
@@ -360,10 +360,13 @@ bool GERBER::ExecuteRS274XCommand( int command,
break
;
case
AP_DEFINITION
:
// input example: %ADD30R,0.081800X0.101500*%
// at this point, text points to 2nd 'D'
/* input example: %ADD30R,0.081800X0.101500*%
* Aperture definition has 4 options: C, R, O, P
* (Circle, Rect, Oval, regular Polygon)
* and shapes can have a hole (round or rectangular).
* All optional parameters values start by X
* at this point, text points to 2nd 'D'
*/
if
(
*
text
++
!=
'D'
)
{
ok
=
FALSE
;
...
...
@@ -391,7 +394,7 @@ bool GERBER::ExecuteRS274XCommand( int command,
dcode
->
m_Size
.
x
=
dcode
->
m_Size
.
y
=
wxRound
(
ReadDouble
(
text
)
*
conv_scale
);
switch
(
stdAperture
)
switch
(
stdAperture
)
// Aperture desceiption has optional parameters. Read them
{
case
'C'
:
// Circle
dcode
->
m_Shape
=
APT_CIRCLE
;
...
...
@@ -403,7 +406,7 @@ bool GERBER::ExecuteRS274XCommand( int command,
text
++
;
dcode
->
m_Drill
.
x
=
dcode
->
m_Drill
.
y
=
wxRound
(
ReadDouble
(
text
)
*
conv_scale
);
dcode
->
m_DrillShape
=
1
;
dcode
->
m_DrillShape
=
APT_DEF_ROUND_HOLE
;
}
while
(
*
text
==
' '
)
...
...
@@ -415,7 +418,7 @@ bool GERBER::ExecuteRS274XCommand( int command,
dcode
->
m_Drill
.
y
=
wxRound
(
ReadDouble
(
text
)
*
conv_scale
);
dcode
->
m_DrillShape
=
2
;
dcode
->
m_DrillShape
=
APT_DEF_RECT_HOLE
;
}
dcode
->
m_Defined
=
TRUE
;
break
;
...
...
@@ -442,7 +445,7 @@ bool GERBER::ExecuteRS274XCommand( int command,
text
++
;
dcode
->
m_Drill
.
x
=
dcode
->
m_Drill
.
y
=
wxRound
(
ReadDouble
(
text
)
*
conv_scale
);
dcode
->
m_DrillShape
=
1
;
dcode
->
m_DrillShape
=
APT_DEF_ROUND_HOLE
;
}
while
(
*
text
==
' '
)
...
...
@@ -453,14 +456,56 @@ bool GERBER::ExecuteRS274XCommand( int command,
text
++
;
dcode
->
m_Drill
.
y
=
wxRound
(
ReadDouble
(
text
)
*
conv_scale
);
dcode
->
m_DrillShape
=
2
;
dcode
->
m_DrillShape
=
APT_DEF_RECT_HOLE
;
}
dcode
->
m_Defined
=
TRUE
;
break
;
case
'P'
:
// Polygon
dcode
->
m_Shape
=
APT_POLYGON
;
dcode
->
m_Defined
=
TRUE
;
case
'P'
:
/* Regular polygon: a command line like %ADD12P,0.040X10X25X0.025X0.025X0.0150*%
* params are: <diameter>, X<edge count>, X<Rotation>, X<X hole dim>, X<Y hole dim>
*/
dcode
->
m_Shape
=
APT_POLYGON
;
while
(
*
text
==
' '
)
text
++
;
if
(
*
text
==
'X'
)
{
text
++
;
dcode
->
m_EdgesCount
=
ReadInt
(
text
);
}
while
(
*
text
==
' '
)
text
++
;
if
(
*
text
==
'X'
)
{
text
++
;
dcode
->
m_Rotation
=
ReadDouble
(
text
);
}
while
(
*
text
==
' '
)
text
++
;
if
(
*
text
==
'X'
)
{
text
++
;
dcode
->
m_Drill
.
x
=
dcode
->
m_Drill
.
y
=
wxRound
(
ReadDouble
(
text
)
*
conv_scale
);
dcode
->
m_DrillShape
=
APT_DEF_ROUND_HOLE
;
}
while
(
*
text
==
' '
)
text
++
;
if
(
*
text
==
'X'
)
{
text
++
;
dcode
->
m_Drill
.
y
=
wxRound
(
ReadDouble
(
text
)
*
conv_scale
);
dcode
->
m_DrillShape
=
APT_DEF_RECT_HOLE
;
}
dcode
->
m_Defined
=
TRUE
;
break
;
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment