work around some gcc 4.3.3 compiler warnings

3d-viewer/3d_draw.cpp

@@ -658,7 +658,7 @@ void EDGE_MODULE::Draw3D( Pcb3D_GLCanvas* glcanvas )
 
     default:
         s.Printf( wxT( "Error: Shape nr %d not implemented!\n" ), m_Shape );
-        printf( CONV_TO_UTF8( s ) );
+        D(printf( "%s", CONV_TO_UTF8( s ) );)
         break;
     }
 }

common/edaappl.cpp

@@ -417,7 +417,7 @@ bool WinEDA_App::SetBinDir()
 
         if( ( ftmp = fopen( TMP_FILE, "rt" ) ) != NULL )
         {
-            fgets( Line, 1000, ftmp );
+            (void) fgets( Line, 1000, ftmp );
             fclose( ftmp );
             remove( TMP_FILE );
         }

common/hotkeys_basic.cpp

@@ -412,12 +412,12 @@ int WinEDA_BasicFrame::WriteHotkeyConfigFile( const wxString&
     wxString keyname, infokey;
 
     msg = wxT( "$hotkey list\n" );
-    fprintf( cfgfile, CONV_TO_UTF8( msg ) );
+    fprintf( cfgfile, "%s", CONV_TO_UTF8( msg ) );
 
     /* print the allowed keys, for info
      */
     msg = wxT( "# " ); msg += _( "Allowed keys:\n" );
-    fprintf( cfgfile, CONV_TO_UTF8( msg ) );
+    fprintf( cfgfile, "%s", CONV_TO_UTF8( msg ) );
     msg.Empty();
     for( int ii = 0; ; ii++ )
     {
@@ -431,7 +431,7 @@ int WinEDA_BasicFrame::WriteHotkeyConfigFile( const wxString&
         if( msg.Len() > 60 )
         {
             msg += wxT( "\n" );
-            fprintf( cfgfile, CONV_TO_UTF8( msg ) );
+            fprintf( cfgfile, "%s", CONV_TO_UTF8( msg ) );
             msg.Empty();
         }
     }
@@ -440,7 +440,7 @@ int WinEDA_BasicFrame::WriteHotkeyConfigFile( const wxString&
     if( !msg.IsEmpty() )
         msg += wxT( "\n" );
     msg += wxT( "#\n#\n" );
-    fprintf( cfgfile, CONV_TO_UTF8( msg ) );
+    fprintf( cfgfile, "%s", CONV_TO_UTF8( msg ) );
 
     /* Print the current hotkey list */
     Ki_HotkeyInfo** List;
@@ -449,12 +449,10 @@ int WinEDA_BasicFrame::WriteHotkeyConfigFile( const wxString&
         if( DescList->m_Comment )
         {
             fprintf( cfgfile, "# " );
-            fprintf( cfgfile, DescList->m_Comment );
-            fprintf( cfgfile, "\n" );
+            fprintf( cfgfile, "%s\n", DescList->m_Comment );
         }
         msg = *DescList->m_SectionTag;
-        fprintf( cfgfile, CONV_TO_UTF8( msg ) );
-        fprintf( cfgfile, "\n" );
+        fprintf( cfgfile, "%s\n", CONV_TO_UTF8( msg ) );
         List = DescList->m_HK_InfoList;
         for( ; *List != NULL; List++ )
         {
@@ -465,12 +463,12 @@ int WinEDA_BasicFrame::WriteHotkeyConfigFile( const wxString&
             infokey = hk_decr->m_InfoMsg;
             AddDelimiterString( infokey );
             msg += keyname + wxT( ":    " ) + infokey + wxT( "\n" );
-            fprintf( cfgfile, CONV_TO_UTF8( msg ) );
+            fprintf( cfgfile, "%s", CONV_TO_UTF8( msg ) );
         }
     }
 
     msg = wxT( "$Endlist\n" );
-    fprintf( cfgfile, CONV_TO_UTF8( msg ) );
+    fprintf( cfgfile, "%s\n", CONV_TO_UTF8( msg ) );
     fclose( cfgfile );
     return 1;
 }

cvpcb/listlib.cpp

@@ -90,7 +90,7 @@ bool LoadFootprintFiles( const wxArrayString& libNames,
         }
 
         /* Check if library type is valid */
-        fgets( buffer, 32, file );
+        (void) fgets( buffer, 32, file );
         if( strncmp( buffer, ENTETE_LIBRAIRIE, L_ENTETE_LIB ) != 0 )
         {
             s_files_invalid << tmp << _(" (Not a Kicad file)") << wxT("\n");

cvpcb/readschematicnetlist.cpp

@@ -118,7 +118,7 @@ int WinEDA_CvpcbFrame::ReadSchematicNetlist()
     /* Read the file header (must be  "( { OrCAD PCB" or "({ OrCAD PCB" )
      * or "# EESchema Netliste"
      */
-    fgets( Line, BUFFER_CHAR_SIZE, source );
+    (void) fgets( Line, BUFFER_CHAR_SIZE, source );
     /* test for netlist type PCB2 */
     i = strnicmp( Line, "( {", 3 );
     if( i != 0 )

cvpcb/writenetlistpcbnew.cpp

@@ -93,7 +93,7 @@ int GenNetlistPcbnew( FILE* file, COMPONENT_LIST& list, bool isEESchemaNetlist,
         fprintf( file, " ( %s ", CONV_TO_UTF8( component.m_TimeStamp ) );
 
         if( !component.m_Module.IsEmpty() )
-            fprintf( file, CONV_TO_UTF8( component.m_Module ) );
+            fprintf( file, "%s", CONV_TO_UTF8( component.m_Module ) );
 
         else
             fprintf( file, "$noname$" );

gerbview/export_to_pcbnew.cpp

@@ -94,7 +94,7 @@ static int WriteSetup( FILE* File, BOARD* Pcb )
 
     fprintf( File, "$SETUP\n" );
     sprintf( text, "InternalUnit %f INCH\n", 1.0 / PCB_INTERNAL_UNIT );
-    fprintf( File, text );
+    fprintf( File, "%s", text );
 
     Pcb->m_BoardSettings->m_CopperLayerCount = g_DesignSettings.m_CopperLayerCount;
     fprintf( File, "Layers %d\n", g_DesignSettings.m_CopperLayerCount );

include/class_drc_item.h

@@ -188,16 +188,16 @@ public:
         {
             ret.Printf( wxT( "ErrType(%d): %s\n    %s: %s\n    %s: %s\n" ),
                        m_ErrorCode,
-                       GetErrorText().GetData(),
-                       ShowCoord( m_MainPosition ).GetData(), m_MainText.GetData(),
-                       ShowCoord( m_AuxiliaryPosition ).GetData(), m_AuxiliaryText.GetData() );
+                       GetChars( GetErrorText() ),
+                       GetChars( ShowCoord( m_MainPosition ) ), GetChars( m_MainText ),
+                       GetChars( ShowCoord( m_AuxiliaryPosition ) ), GetChars( m_AuxiliaryText ) );
         }
         else
         {
             ret.Printf( wxT( "ErrType(%d): %s\n    %s: %s\n" ),
                        m_ErrorCode,
-                       GetErrorText().GetData(),
-                       ShowCoord( m_MainPosition ).GetData(), m_MainText.GetData() );
+                       GetChars( GetErrorText() ),
+                       GetChars( ShowCoord( m_MainPosition ) ), GetChars( m_MainText ) );
         }
 
         return ret;

pcbnew/build_BOM_from_board.cpp

@@ -90,7 +90,7 @@ void WinEDA_PcbFrame::RecreateBOMFileFromBoard( wxCommandEvent& aEvent )
     msg << _("Number") << wxT("\";\"");
     msg << _("Designation") << wxT("\";\"");
     msg << _("Supplier and ref") << wxT("\";\n" );
-    fprintf( FichBom, CONV_TO_UTF8( msg ) );
+    fprintf( FichBom, "%s", CONV_TO_UTF8( msg ) );
 
     // Build list
     CmpList           list;
@@ -142,7 +142,7 @@ void WinEDA_PcbFrame::RecreateBOMFileFromBoard( wxCommandEvent& aEvent )
         msg << current->m_Pkg << wxT( "\";" );
         msg << current->m_CmpCount << wxT( ";\"" );
         msg << current->m_Val << wxT( "\";;;\n" );
-        fprintf( FichBom, CONV_TO_UTF8( msg ) );
+        fprintf( FichBom, "%s", CONV_TO_UTF8( msg ) );
 
         list.DeleteObject( current );
         delete (current);

pcbnew/class_module.cpp

@@ -365,19 +365,19 @@ int MODULE::Write_3D_Descr( FILE* File ) const
                 t3D->m_MatScale.x,
                 t3D->m_MatScale.y,
                 t3D->m_MatScale.z );
-            fprintf( File, to_point( buf ) );
+            fprintf( File, "%s", to_point( buf ) );
 
             sprintf( buf, "Of %lf %lf %lf\n",
                 t3D->m_MatPosition.x,
                 t3D->m_MatPosition.y,
                 t3D->m_MatPosition.z );
-            fprintf( File, to_point( buf ) );
+            fprintf( File, "%s", to_point( buf ) );
 
             sprintf( buf, "Ro %lf %lf %lf\n",
                 t3D->m_MatRotation.x,
                 t3D->m_MatRotation.y,
                 t3D->m_MatRotation.z );
-            fprintf( File, to_point( buf ) );
+            fprintf( File, "%s", to_point( buf ) );
 
             fprintf( File, "$EndSHAPE3D\n" );
         }

pcbnew/dialog_drc.cpp

@@ -523,14 +523,14 @@ void DIALOG_DRC_CONTROL::writeReport( FILE* fp )
     fprintf( fp, "\n** Found %d DRC errors **\n", count );
 
     for( int i = 0;  i<count;  ++i )
-        fprintf( fp, m_ClearanceListBox->GetItem( i )->ShowReport().mb_str() );
+        fprintf( fp, "%s", CONV_TO_UTF8( m_ClearanceListBox->GetItem( i )->ShowReport()) );
 
     count = m_UnconnectedListBox->GetItemCount();
 
     fprintf( fp, "\n** Found %d unconnected pads **\n", count );
 
     for( int i = 0;  i<count;  ++i )
-        fprintf( fp, m_UnconnectedListBox->GetItem( i )->ShowReport().mb_str() );
+        fprintf( fp, "%s", CONV_TO_UTF8( m_UnconnectedListBox->GetItem( i )->ShowReport() ) );
 
     fprintf( fp, "\n** End of Report **\n" );
 }

pcbnew/ioascii.cpp

@@ -524,7 +524,7 @@ static int WriteSetup( FILE* aFile, WinEDA_BasePcbFrame* aFrame, BOARD* aBoard )
 
     fprintf( aFile, "$SETUP\n" );
     sprintf( text, "InternalUnit %f INCH\n", 1.0 / PCB_INTERNAL_UNIT );
-    fprintf( aFile, text );
+    fprintf( aFile, "%s", text );
 
     fprintf( aFile, "ZoneGridSize %d\n", g_GridRoutingSize );
 

pcbnew/onrightclick.cpp

@@ -881,7 +881,7 @@ static wxMenu* Append_Track_Width_List( BOARD * aBoard )
         trackwidth_menu->Check( ID_POPUP_PCB_SELECT_AUTO_WIDTH, true );
     else
     {
-        if( aBoard->m_TrackWidthSelector < (int)aBoard->m_TrackWidthHistory.size() )
+        if( aBoard->m_TrackWidthSelector < aBoard->m_TrackWidthHistory.size() )
             trackwidth_menu->Check( ID_POPUP_PCB_SELECT_WIDTH1 + aBoard->m_TrackWidthSelector, true );
     }
 
@@ -899,7 +899,7 @@ static wxMenu* Append_Track_Width_List( BOARD * aBoard )
             msg << _(" (from NetClass)" );
         trackwidth_menu->Append( ID_POPUP_PCB_SELECT_VIASIZE1 + ii, msg, wxEmptyString, true );
     }
-    if( aBoard->m_ViaSizeSelector < (int)aBoard->m_ViaSizeHistory.size() )
+    if( aBoard->m_ViaSizeSelector < aBoard->m_ViaSizeHistory.size() )
         trackwidth_menu->Check( ID_POPUP_PCB_SELECT_VIASIZE1 + aBoard->m_ViaSizeSelector, true );
 
     return trackwidth_menu;

pcbnew/xchgmod.cpp

@@ -192,7 +192,7 @@ int DIALOG_EXCHANGE_MODULE::Maj_ListeCmp( const wxString& reference,
         return 1;
     }
 
-    fgets( Line, sizeof(Line), FichCmp );
+    (void) fgets( Line, sizeof(Line), FichCmp );
     fprintf( NewFile, "Cmp-Mod V01 Genere par PcbNew le %s\n",
             DateAndTime( Line ) );
 
@@ -601,7 +601,7 @@ void WinEDA_PcbFrame::RecreateCmpFileFromBoard( wxCommandEvent& aEvent )
         return;
     }
 
-    fgets( Line, sizeof(Line), FichCmp );
+    (void) fgets( Line, sizeof(Line), FichCmp );
     fprintf( FichCmp, "Cmp-Mod V01 Genere par PcbNew le %s\n",
             DateAndTime( Line ) );