Coverity fixes.

common/gal/opengl/gpu_manager.cpp

@@ -55,7 +55,7 @@ GPU_MANAGER* GPU_MANAGER::MakeManager( VERTEX_CONTAINER* aContainer )
 
 
 GPU_MANAGER::GPU_MANAGER( VERTEX_CONTAINER* aContainer ) :
-    m_isDrawing( false ), m_container( aContainer ), m_shader( NULL )
+    m_isDrawing( false ), m_container( aContainer ), m_shader( NULL ), m_shaderAttrib( 0 )
 {
 }
 
@@ -80,8 +80,8 @@ void GPU_MANAGER::SetShader( SHADER& aShader )
 
 // Cached manager
 GPU_CACHED_MANAGER::GPU_CACHED_MANAGER( VERTEX_CONTAINER* aContainer ) :
-    GPU_MANAGER( aContainer ), m_buffersInitialized( false ),
-    m_indicesSize( 0 )
+    GPU_MANAGER( aContainer ), m_buffersInitialized( false ), m_indicesPtr( NULL ),
+    m_verticesBuffer( 0 ), m_indicesBuffer( 0 ), m_indicesSize( 0 )
 {
     // Allocate the biggest possible buffer for indices
     m_indices.reset( new GLuint[aContainer->GetSize()] );

common/geometry/seg.cpp

@@ -52,7 +52,7 @@ bool SEG::PointCloserThan( const VECTOR2I& aP, int aDist ) const
         int cb = sgn( d.x );
         int cc = -ca * A.x - cb * A.y;
 
-        ecoord num = ca * aP.x + cb * aP.y + cc;
+        ecoord num = (ecoord) ca * aP.x + (ecoord) cb * aP.y + cc;
         num *= num;
 
         if( ca && cb )

pcbnew/dialogs/dialog_pad_properties.cpp

@@ -930,11 +930,11 @@ void DIALOG_PAD_PROPERTIES::PadPropertiesAccept( wxCommandEvent& event )
         {
             const NETINFO_ITEM* netinfo = m_board->FindNet( padNetname );
 
-            if( !padNetname.IsEmpty() &&  netinfo == NULL )
+            if( !padNetname.IsEmpty() && netinfo == NULL )
             {
                 DisplayError( NULL, _( "Unknown netname, netname not changed" ) );
             }
-            else
+            else if( netinfo )
             {
                 rastnestIsChanged = true;
                 m_currentPad->SetNetCode( netinfo->GetNet() );

pcbnew/tools/selection_tool.cpp

@@ -1302,8 +1302,18 @@ void SELECTION_TOOL::generateMenu()
     // Filter out entries that does not apply to the current selection
     for( int i = m_menuCopy.GetMenuItemCount() - 1; i >= 0; --i )
     {
-        if( !m_menuConditions[i]( m_selection ) )
+        try
         {
+            if( !m_menuConditions[i]( m_selection ) )
+            {
+                wxMenuItem* item = m_menuCopy.FindItemByPosition( i );
+                m_menuCopy.Destroy( item );
+            }
+        }
+        catch( boost::bad_function_call )
+        {
+            // If it is not possible to determine if a menu entry should be
+            // shown or not - do not let users pick non-existing options
             wxMenuItem* item = m_menuCopy.FindItemByPosition( i );
             m_menuCopy.Destroy( item );
         }