Commit 74cc5a75 authored by Dick Hollenbeck's avatar Dick Hollenbeck
Browse files

fix Bug #578532, document and embellish QuoteFullPath()

parent d9c42e27

common/gestfich.cpp

+1 −1
Original line number Diff line number Diff line
@@ -685,5 +685,5 @@ void OpenFile( const wxString& file ) 


wxString QuoteFullPath( wxFileName& fn, wxPathFormat format )

{

    return wxT( "\"" ) + fn.GetFullPath() + wxT( "\"" );

    return wxT( "\"" ) + fn.GetFullPath( format ) + wxT( "\"" );

}

eeschema/schframe.cpp

+6 −3
Original line number Diff line number Diff line
@@ -702,8 +702,11 @@ void WinEDA_SchematicFrame::OnOpenPcbnew( wxCommandEvent& event ) 


    if( fn.IsOk() )

    {

        fn.ClearExt();

        ExecuteFile( this, PCBNEW_EXE, QuoteFullPath( fn ) );

        fn.SetExt( BoardFileExtension );



        wxString filename = QuoteFullPath( fn );



        ExecuteFile( this, PCBNEW_EXE, filename );

    }

    else

        ExecuteFile( this, PCBNEW_EXE );

include/gestfich.h

+4 −2
Original line number Diff line number Diff line
@@ -77,8 +77,10 @@ wxString FindKicadFile( const wxString& shortname ); 
 * Quote return value of wxFileName::GetFullPath().

 *

 * This allows file name paths with spaces to be used as parameters to

 * ProcessExecute function calls.  This is a cheap and dirty hack and

 * should probably should be done in a class derived from wxFileName.

 * ProcessExecute function calls.

 * @param fn is the filename to wrap

 * @param format if provided, can be used to transform the nature of the

 *    wrapped filename to another platform.

 */

extern wxString QuoteFullPath( wxFileName& fn,

                               wxPathFormat format = wxPATH_NATIVE );