Commit 64925bfc authored by jean-pierre charras's avatar jean-pierre charras
Browse files

Very minor fixes: add missing const return type to some GetBoundingBox()... 

Very minor fixes: add missing const return type to some GetBoundingBox() declarations. Change few functions names to better names in some places (like GetName() to GetPinName() )
parent 8876fdf4

common/class_bitmap_base.cpp

+1 −1
Original line number Original line Diff line number Diff line
@@ -197,7 +197,7 @@ bool BITMAP_BASE::LoadData( LINE_READER& aLine, wxString& aErrorMsg ) 
}

}









EDA_RECT BITMAP_BASE::GetBoundingBox() const

const EDA_RECT BITMAP_BASE::GetBoundingBox() const

{

{

    EDA_RECT rect;

    EDA_RECT rect;

eeschema/class_libentry.cpp

+2 −2
Original line number Original line Diff line number Diff line
@@ -1055,7 +1055,7 @@ bool LIB_PART::LoadFootprints( LINE_READER& aLineReader, wxString& aErrorMsg ) 
}

}









EDA_RECT LIB_PART::GetBoundingBox( int aUnit, int aConvert ) const

const EDA_RECT LIB_PART::GetBoundingBox( int aUnit, int aConvert ) const

{

{

    EDA_RECT bBox( wxPoint( 0, 0 ), wxSize( 0, 0 ) );

    EDA_RECT bBox( wxPoint( 0, 0 ), wxSize( 0, 0 ) );
@@ -1080,7 +1080,7 @@ EDA_RECT LIB_PART::GetBoundingBox( int aUnit, int aConvert ) const 
}

}









EDA_RECT LIB_PART::GetBodyBoundingBox( int aUnit, int aConvert ) const

const EDA_RECT LIB_PART::GetBodyBoundingBox( int aUnit, int aConvert ) const

{

{

    EDA_RECT bBox( wxPoint( 0, 0 ), wxSize( 0, 0 ) );

    EDA_RECT bBox( wxPoint( 0, 0 ), wxSize( 0, 0 ) );

eeschema/class_libentry.h

+2 −2
Original line number Original line Diff line number Diff line
@@ -296,7 +296,7 @@ public: 
     *  if aConvert == 0 Convert is non used

     *  if aConvert == 0 Convert is non used

     *  Invisible fields are not taken in account

     *  Invisible fields are not taken in account

     **/

     **/

    EDA_RECT GetBoundingBox( int aUnit, int aConvert ) const;

    const EDA_RECT GetBoundingBox( int aUnit, int aConvert ) const;





    /**

    /**

     * Function GetBodyBoundingBox

     * Function GetBodyBoundingBox
@@ -307,7 +307,7 @@ public: 
     *  if aConvert == 0 Convert is non used

     *  if aConvert == 0 Convert is non used

     *  Fields are not taken in account

     *  Fields are not taken in account

     **/

     **/

    EDA_RECT GetBodyBoundingBox( int aUnit, int aConvert ) const;

    const EDA_RECT GetBodyBoundingBox( int aUnit, int aConvert ) const;





    /**

    /**

     * Function SaveDateAndTime

     * Function SaveDateAndTime

eeschema/dialogs/dialog_lib_edit_pin.cpp

+2 −2
Original line number Original line Diff line number Diff line
@@ -118,14 +118,14 @@ void DIALOG_LIB_EDIT_PIN::OnPropertiesChange( wxCommandEvent& event ) 
    if( ! IsShown() )   // do nothing at init time

    if( ! IsShown() )   // do nothing at init time

        return;

        return;





    int pinNameSize = ValueFromString( g_UserUnit, GetNameTextSize() );

    int pinNameSize = ValueFromString( g_UserUnit, GetPinNameTextSize() );

    int pinNumSize = ValueFromString( g_UserUnit, GetPadNameTextSize());

    int pinNumSize = ValueFromString( g_UserUnit, GetPadNameTextSize());

    int pinOrient = LIB_PIN::GetOrientationCode( GetOrientation() );

    int pinOrient = LIB_PIN::GetOrientationCode( GetOrientation() );

    int pinLength = ValueFromString( g_UserUnit, GetLength() );

    int pinLength = ValueFromString( g_UserUnit, GetLength() );

    int pinShape = LIB_PIN::GetStyleCode( GetStyle() );

    int pinShape = LIB_PIN::GetStyleCode( GetStyle() );

    int pinType = GetElectricalType();

    int pinType = GetElectricalType();





    m_dummyPin->SetName( GetName() );

    m_dummyPin->SetName( GetPinName() );

    m_dummyPin->SetNameTextSize( pinNameSize );

    m_dummyPin->SetNameTextSize( pinNameSize );

    m_dummyPin->SetNumber( GetPadName() );

    m_dummyPin->SetNumber( GetPadName() );

    m_dummyPin->SetNumberTextSize( pinNumSize );

    m_dummyPin->SetNumberTextSize( pinNumSize );

eeschema/dialogs/dialog_lib_edit_pin.h

+5 −5
Original line number Original line Diff line number Diff line
@@ -71,19 +71,19 @@ public: 
    void SetStyle( int style ) { m_choiceStyle->SetSelection( style ); }

    void SetStyle( int style ) { m_choiceStyle->SetSelection( style ); }

    int GetStyle( void ) { return m_choiceStyle->GetSelection(); }

    int GetStyle( void ) { return m_choiceStyle->GetSelection(); }





    void SetName( const wxString& name ) { m_textPinName->SetValue( name ); }

    void SetPinName( const wxString& name ) { m_textPinName->SetValue( name ); }

    wxString GetName( void ) { return m_textPinName->GetValue(); }

    wxString GetPinName( void ) { return m_textPinName->GetValue(); }





    void SetNameTextSize( const wxString& size )

    void SetPinNameTextSize( const wxString& size )

    {

    {

        m_textPinNameTextSize->SetValue( size );

        m_textPinNameTextSize->SetValue( size );

    }

    }

    wxString GetNameTextSize( void )

    wxString GetPinNameTextSize( void )

    {

    {

        return m_textPinNameTextSize->GetValue();

        return m_textPinNameTextSize->GetValue();

    }

    }





    void SetNameTextSizeUnits( const wxString& units )

    void SetPinNameTextSizeUnits( const wxString& units )

    {

    {

        m_staticNameTextSizeUnits->SetLabel( units );

        m_staticNameTextSizeUnits->SetLabel( units );

    }

    }