Commit 28f3b198 authored by charras's avatar charras
Browse files

Pcbnew: Code cleaning about visibility variables in draw functions. 

Removed old color and visiblity dialog
work in progress.
See also TODO, P0)
parent 99b3739c

CHANGELOG.txt

+7 −0
Original line number Diff line number Diff line
@@ -4,6 +4,13 @@ KiCad ChangeLog 2010 
Please add newer entries at the top, list the date and your name with

email address.



2010-Jan-27 UPDATE Jean-Pierre Charras <jean-pierre.charras@gipsa-lab.inpg.fr>

================================================================================

++ Pcbnew:

    Code cleaning about visibility variables (dulpicates) in draw functions.

    Removed old color and visiblity dialog

    work in progress



2010-Jan-24 UPDATE Jean-Pierre Charras <jean-pierre.charras@gipsa-lab.inpg.fr>

================================================================================

++ Pcbnew:

TODO.txt

+9 −0
Original line number Diff line number Diff line
@@ -59,9 +59,18 @@ from folks with less than that minimum. 


PCBNew

------

P0) JP Charras:

    We should need to separate color handling from visibility handling:

    Visibilty variables nus be owned by the current board.

    (Modedit and Board editor must have separate visibility options:

     Modedit should have always all items and layers visibles)

    Colors options must be left global

    (Modedit and Board editor must have common color options)



P1) Fix the color box which shows which layer is selected, or change tool tip.

    It is not tracking layer changes.  Look into WinEDA_PcbFrame::syncLayerBox(),

    which is probably where fix should go.

    >> JP Charras: For me this is now working.



Dick:

P2) Write accessors for all items in PCB_VISIBLE such as grid control, so that

include/class_board_design_settings.h

+6 −0
Original line number Diff line number Diff line
@@ -59,6 +59,12 @@ public: 
     */

    int  GetVisibleLayers() const;



    /**

     * Function SetVisibleAlls

     * Set the bit-mask of all visible elements categories, including layers

     */

    void SetVisibleAlls( );



    /**

     * Function SetVisibleLayers

     * changes the bit-mask of visible layers

include/pcbstruct.h

+0 −3
Original line number Diff line number Diff line
@@ -300,9 +300,6 @@ public: 
                                 * 3 show netnames on tracks and pads

                                 */



    bool Show_Modules_Cmp;

    bool Show_Modules_Cu;



    int  DisplayDrawItems;

    bool ContrastModeDisplay;

include/wxBasePcbFrame.h

+2 −2
Original line number Diff line number Diff line
@@ -54,8 +54,8 @@ public: 
    bool m_DisplayViaFill;          // How show vias

    bool m_DisplayPadNum;           // show pads numbers



    int  m_DisplayModEdge;          // How show module drawings

    int  m_DisplayModText;          // How show module texts

    int  m_DisplayModEdge;          // How to display module drawings (line/ filled / sketch)

    int  m_DisplayModText;          // How to display module texts (line/ filled / sketch)

    bool m_DisplayPcbTrackFill;     /* FALSE : tracks are show in sketch mode,

                                     * TRUE = filled */

    int  m_UserGridUnits;