Commit 1a708967 authored by Adrian Negreanu's avatar Adrian Negreanu
Browse files

sqlite3: clear bindings on errors and more care with return 



* call sqlite3_clear_bindings when step fails
* more miss-placed returns

Signed-off-by: default avatarAdrian Negreanu <adrian.m.negreanu@intel.com>
parent 09a5fc19

src/sqlite3gen.cpp

+18 −12
Original line number Diff line number Diff line
@@ -708,9 +708,9 @@ static void generateSqlite3ForMember(sqlite3*db,MemberDef *md,Definition *def) 
        if (id_bfile == -1)

        {

            sqlite3_clear_bindings(i_s_memberdef);

            return;

        }



        else

        {

            bindIntParameter(i_s_memberdef,":id_ibfile",id_bfile);

            bindIntParameter(i_s_memberdef,":bline",md->getStartBodyLine());
@@ -719,12 +719,13 @@ static void generateSqlite3ForMember(sqlite3*db,MemberDef *md,Definition *def) 
        }

      }

    }

  }



  if (-1==step(db,i_s_memberdef))

  {

      sqlite3_clear_bindings(i_s_memberdef);

  }

  /*int id_src =*/ sqlite3_last_insert_rowid(db);

  sqlite3_last_insert_rowid(db);



  // + source references

  // The cross-references in initializers only work when both the src and dst
@@ -825,8 +826,9 @@ static void generateSqlite3ForClass(sqlite3 *db, ClassDef *cd) 
  bindIntParameter(i_s_compounddef,":line",cd->getDefLine());

  bindIntParameter(i_s_compounddef,":column",cd->getDefColumn());



  if (-1==step(db,i_s_compounddef))

    return;

  if (-1==step(db,i_s_compounddef)) {

    sqlite3_clear_bindings(i_s_compounddef);

  }



  // + list of direct super classes

  if (cd->baseClasses())
@@ -848,10 +850,12 @@ static void generateSqlite3ForClass(sqlite3 *db, ClassDef *cd) 
        bindTextParameter(i_s_basecompoundref,":base",bcd->classDef->displayName());

      }

      bindTextParameter(i_s_basecompoundref,":derived",cd->displayName());

      if (-1==step(db,i_s_basecompoundref))

      if (-1==step(db,i_s_basecompoundref)) {

        sqlite3_clear_bindings(i_s_basecompoundref);

        continue;

      }

    }

  }



  // + list of direct sub classes

  if (cd->subClasses())
@@ -865,10 +869,12 @@ static void generateSqlite3ForClass(sqlite3 *db, ClassDef *cd) 
      bindTextParameter(i_s_derivedcompoundref,":refid",bcd->classDef->getOutputFileBase());

      bindIntParameter(i_s_derivedcompoundref,":prot",bcd->prot);

      bindIntParameter(i_s_derivedcompoundref,":virt",bcd->virt);

      if (-1==step(db,i_s_derivedcompoundref))

      if (-1==step(db,i_s_derivedcompoundref)) {

        sqlite3_reset(i_s_derivedcompoundref);

        continue;

      }

    }

  }



  // + include file

  IncludeInfo *ii=cd->includeInfo();
@@ -888,7 +894,7 @@ static void generateSqlite3ForClass(sqlite3 *db, ClassDef *cd) 
        bindIntParameter(i_s_includes,":id_src",id_file);

        bindTextParameter(i_s_includes,":dst",nm);

        if (-1==step(db,i_s_includes))

          return;

          sqlite3_clear_bindings(i_s_basecompoundref);

      }

    }

  }