working on multiple sensors per port, adde GRR configuration

eclipse_project_setup/.externalToolBuilders/bitbake deploy [Builder].launch

 <?xml version="1.0" encoding="UTF-8" standalone="no"?>
 <launchConfiguration type="org.eclipse.ui.externaltools.ProgramBuilderLaunchConfigurationType">
 <booleanAttribute key="org.eclipse.debug.ui.ATTR_LAUNCH_IN_BACKGROUND" value="false"/>
-<listAttribute key="org.eclipse.debug.ui.favoriteGroups">
-<listEntry value="org.eclipse.ui.externaltools.launchGroup"/>
-</listAttribute>
 <booleanAttribute key="org.eclipse.ui.externaltools.ATTR_BUILDER_ENABLED" value="false"/>
 <stringAttribute key="org.eclipse.ui.externaltools.ATTR_LAUNCH_CONFIGURATION_BUILD_SCOPE" value="${none}"/>
 <stringAttribute key="org.eclipse.ui.externaltools.ATTR_LOCATION" value="${workspace_loc:/linux-elphel/run_bitbake.sh}"/>

src/arch/arm/boot/dts/elphel393.dts

@@ -252,11 +252,11 @@
 
     elphel393_detect_sensors: elphel393-detect_sensors@0 {
         compatible = "elphel,elphel393-detect_sensors-1.00";
-        elphel393-detect_sensors,port-mux = "none none none none"; /* "none", "detect" or "mux10359" */
-        elphel393-detect_sensors,sensors =  "mt9p006", // Line per port, may contain up to 4 sensors (3 with 10359)
-                                            "mt9p006",
-                                            "mt9p006",
-                                            "mt9p006";
+        elphel393-detect_sensors,port-mux = "mux10359 mux10359 mux10359 mux10359"; /* "none", "detect" or "mux10359" */
+        elphel393-detect_sensors,sensors =  "mt9p006 mt9p006 mt9p006", // Line per port, may contain up to 4 sensors (3 with 10359)
+                                            "mt9p006 mt9p006 mt9p006",
+                                            "mt9p006 mt9p006 mt9p006",
+                                            "mt9p006 mt9p006 mt9p006";
     };
     
     elphel393_sensor_i2c: elphel393-sensor-i2c@0 {

src/drivers/elphel/fpgajtag353.c

@@ -422,6 +422,10 @@ static int fpga_jtag_release(struct inode *inode, struct file *filp) {
     if (JTAG_channels[chn].wp > 0) { // anything written?
         res=JTAG_configure (chn, JTAG_channels[chn].dbuf, JTAG_channels[chn].wp);
         JTAG_resetChannel (chn);
+        if (res <0) {
+            dev_dbg(NULL, "fpga_jtag_release:  failure, returned %d\n",res);
+        }
+
         if ((res >=0) & (chn == JTAG_MAIN_FPGA)) {
             // read FPGA model number/revision and OR it with current state
             //fpga_state =  (fpga_state & ~0xffff) | (port_csp0_addr[X313__RA__MODEL] & 0xffff);
@@ -641,8 +645,8 @@ static loff_t  fpga_jtag_lseek(struct file * file, loff_t offset, int orig) {
 // Initialize GPIOs of the CPU to access JTAG/programming of the main FPGA
 void initPortC(void) {
     // connect 8 lower bits of port C to GPIO, disconnect from IOP
-    unsigned long tmp;
 #ifdef TEST_DISABLE_CODE
+    unsigned long tmp;
     reg_pinmux_rw_pc_iop    pinmux_c_iop;
     reg_pinmux_rw_pc_gio    pinmux_c_gio;
     reg_gio_rw_pc_oe        pc_oe;
@@ -758,7 +762,7 @@ inline u32 read_tdo_byte(int sens_num)
 // set FPGA in programming/JTAG mode (only for sensor board)
 // NOP for the main board FPGA configuration
 void set_pgm_mode (int chn, int en) {
-    u32 seq_num;
+//    u32 seq_num;
     x393_sensio_jtag_t data;
     dev_dbg(NULL, "set_pgm_mode (%d,%d)\n",chn,en);
 
@@ -782,7 +786,7 @@ void set_pgm_mode (int chn, int en) {
 }
 
 void set_pgm (int chn, int pgmon) {
-    u32 seq_num;
+//    u32 seq_num;
     x393_sensio_jtag_t data;
     dev_dbg(NULL, "set_pgm (%d,%d)\n",chn,pgmon);
 
@@ -809,8 +813,7 @@ void set_pgm (int chn, int pgmon) {
 
 int read_done (int chn) {
     x393_status_sens_io_t stat;
-    x393_sensio_jtag_t data;
-
+//    x393_sensio_jtag_t data;
     switch (chn >> 2) {
 #ifdef TEST_DISABLE_CODE
     case JTAG_MAIN_FPGA:
@@ -833,7 +836,7 @@ int read_done (int chn) {
 int jtag_send (int chn, int tms, int len, int d) {
     int sens_num = chn & 3;
     x393_sensio_jtag_t data;
-    x393_status_sens_io_t stat;
+//    x393_status_sens_io_t stat;
     //	u32 seq_num;
     int i, bm = 0; //,m;
     int r=0;
@@ -941,7 +944,7 @@ int jtag_write_bits (int chn,
     int bm = 0;
     int d,d0;
     //	u32 seq_num;
-    x393_status_sens_io_t stat;
+//    x393_status_sens_io_t stat;
     x393_sensio_jtag_t data;
 
     dev_dbg(NULL, "jtag_write_bits(0x%x, 0x%x, 0x%x, 0x%x, 0x%x)\r\n", (int) chn, (int) buf, len, check, last);
@@ -1356,7 +1359,7 @@ int JTAG_EXTEST (int chn, unsigned char * buf, int len) {
 #ifdef JTAG_DISABLE_IRQ
     unsigned long flags;
 #endif
-    int i; // only in debug
+//    int i; // only in debug
 #ifdef JTAG_DISABLE_IRQ
     local_irq_save(flags);
     //local_irq_disable();

src/drivers/elphel/mt9x001.c

@@ -1988,9 +1988,11 @@ int mt9x001_pgm_triggermode        (int sensor_port,               ///< sensor p
     unsigned long newreg;
     dev_dbg(g_dev_ptr,"{%d}  frame16=%d\n",sensor_port,frame16);
     if (frame16 >= PARS_FRAMES) return -1; // wrong frame
-    newreg= (thispars->pars[P_SENSOR_REGS+P_MT9X001_RMODE1] & 0xfeff) | ((thispars->pars[P_TRIG] & 4)?0x100:0);
+    newreg= (thispars->pars[P_SENSOR_REGS+P_MT9X001_RMODE1] & 0xfe7f) | // old value without snamshot and GRR bits
+            ((thispars->pars[P_TRIG] & 4)?0x100:0) |                    // snapshot mode for P_TRIG==4 or 5
+            ((thispars->pars[P_TRIG] & 1)?0x80:0);                      // GRR mode for P_TRIG==5 (no effect for 1
     if (newreg != thispars->pars[P_SENSOR_REGS+P_MT9X001_RMODE1]) {
-        // turn off triggered mode immediately, turn on later (or should made at leas before changing camsync parameters)
+        // turn off triggered mode immediately, turn on later (or should made at least before changing camsync parameters)
         if (!(thispars->pars[P_TRIG] & 4)){
             frame16 = -1;
         }

src/drivers/elphel/sensor_common.h

@@ -123,7 +123,7 @@ long long get_frame_pos(unsigned int chn, unsigned int pos);
  * @param reg sensor register address (8-bit)
  * @param datap pointer to receive data
  * @return  0 on success, < 0 - error (ETIMEDOUT) */
-#define X3X3_I2C_RCV2(port,sa7,reg,datap) legacy_read_i2c_reg((port),(LEGACY_READ_PAGE2),(sa7),(reg),2,(datap))
+#define X3X3_I2C_RCV2(port,sa7,reg,datap) legacy_read_i2c_reg((port),(LEGACY_READ_PAGE2),(sa7),(reg),2, (int*)(datap))
 
 /** Perform I2C read (8  bits address, 32 bits data in "legacy" mode (10359 in 32-bit mode),
  * page LEGACY_READ_PAGE2 (==0xff) should be registered - legacy_i2c.
@@ -134,7 +134,7 @@ long long get_frame_pos(unsigned int chn, unsigned int pos);
  * @param reg sensor register address (8-bit)
  * @param datap pointer to receive data
  * @return  0 on success, < 0 - error (ETIMEDOUT) */
-#define X3X3_I2C_RCV4(port,sa7,reg,datap) legacy_read_i2c_reg((port),(LEGACY_READ_PAGE4),(sa7),(reg),4,(datap))
+#define X3X3_I2C_RCV4(port,sa7,reg,datap) legacy_read_i2c_reg((port),(LEGACY_READ_PAGE4),(sa7),(reg),4,(int*)(datap))
 
 int legacy_i2c  (int ports);
 void udelay1000(int ms);