Commit e8fef505 authored by charras's avatar charras
Browse files

Pcbnew: fixed a double deletion that crashes pcbnew. Starting my work on net... 

Pcbnew: fixed a double deletion that crashes pcbnew. Starting my work on net classes (moving target)
parent ee661525

CHANGELOG.txt

+39 −0
Original line number Diff line number Diff line
@@ -4,6 +4,45 @@ KiCad ChangeLog 2009 
Please add newer entries at the top, list the date and your name with

email address.



2009-sept-27 UPDATE Jean-Pierre Charras <jean-pierre.charras@gipsa-lab.inpg.fr>

================================================================================

++pcbnew

    * make pcbnew compatible with last changes

        (Delete base screen in WinEDA_DrawFrame destructor to prevent potential memory leak.)

    * Starting complementary work on Net Classes (moving target)



2009-sept-25 UPDATE Wayne Stambaugh <stambaughw@verizon.net>

================================================================================

Component library editor improvements and minor bug fixes.

* Component library objects renamed for improved readability.

* Fields now move when selected in library editor.

* Add copy constructor to all library draw and library component objects.

* Added copy constructor to EDA_BaseStruct.

* Delete base screen in WinEDA_DrawFrame destructor to prevent potential memory leak.

* Fixed memory access bug when replacing and adding a component to library.

* Moved library component block manipulation code into component object.

* Removed all of the global variables used by the library editor main window object.

* The usual code cleaning and refactoring.



2009-sept-22:

Command ID refactoring and other minor improvements.

* Split out application specific command IDs to prevent unnecessary rebuilding.

* Eliminate duplicate menu and tool bar command IDs.

* Split component library editor and viewer definitions to separate header files.

* More component library and document file merge code.

* A bunch of minor string readability and consistency fixes.



2009-sept-18:

Component library object and other minor improvements.

* Create static component library methods to manage library list.

* Rename component library, component, and alias objects to more readable name.

* Use pointer to component instead of root name to prevent redundant library searches.

* Add append message helper to message panel that calculates string length.

* Initial ground work for merging library and library document files.

* Improved component library file load error checking.

* Minor component library editor improvements.





2009-sept-17 UPDATE Jean-Pierre Charras <jean-pierre.charras@gipsa-lab.inpg.fr>

================================================================================

++pcbnew

include/base_struct.h

+0 −3
Original line number Diff line number Diff line
@@ -75,9 +75,6 @@ enum KICAD_T { 
    COMPONENT_FIELD_DRAW_TYPE,

    COMPONENT_BEZIER_DRAW_TYPE,



    // Special id used to store clearance values (this is not a good idea: TODO: change it)

    TYPE_CLEARANCE,



    // End value

    MAX_STRUCT_TYPE_ID

};

include/board_item_struct.h

+5 −0
Original line number Diff line number Diff line
@@ -281,6 +281,11 @@ public: 
      * returns the NETCLASS for this item.

      */

     NETCLASS* GetNetClass() const;



    /** function GetNetClassName

     * @return the Net Class name of this item

     */

    wxString GetNetClassName( ) const;

};

include/pcbstruct.h

+0 −1
Original line number Diff line number Diff line
@@ -156,7 +156,6 @@ public: 
    int    m_PcbTextWidth;                          // current Pcb (not module) Text width

    wxSize m_PcbTextSize;                           // current Pcb (not module) Text size

    int    m_TrackClearance;                        // track to track and track to pads clearance

    int    m_TrackClearanceHistory[HISTORY_NUMBER]; // Last HISTORY_NUMBER used track widths

    int    m_TrackMinWidth;                         // track min value for width ((min copper size value

    int    m_ViasMinSize;                           // vias (not micro vias) min diameter

    int    m_MicroViasMinSize;                      // micro vias (not vias) min diameter

include/wxPcbStruct.h

+19 −2
Original line number Diff line number Diff line
@@ -53,12 +53,12 @@ class WinEDA_PcbFrame: public WinEDA_BasePcbFrame 
public:

    WinEDAChoiceBox* m_SelLayerBox;

    WinEDAChoiceBox* m_SelTrackWidthBox;

    WinEDAChoiceBox* m_SelClrWidthBox;

    wxTextCtrl* m_ClearanceBox;

    wxTextCtrl* m_NetClassSelectedBox;

    WinEDAChoiceBox* m_SelViaSizeBox;



private:

    bool             m_SelTrackWidthBox_Changed;

    bool             m_SelClrWidthBox_Changed;

    bool             m_SelViaSizeBox_Changed;



    DRC*             m_drc;         ///< the DRC controller, see drc.cpp
@@ -112,6 +112,7 @@ public: 
     */

    void             ShowDesignRulesEditor( wxCommandEvent& event );



    /* toolbars update UI functions: */

    /**

     * Function UpdateToolbarLayerInfo

     * updates the currently selected layer in the layer listbox and
@@ -120,6 +121,22 @@ public: 
    void             UpdateToolbarLayerInfo();



    void             PrepareLayerIndicator();



    /**

     * Function AuxiliaryToolBar_Update_UI

     * update the displayed values on auxiliary horizontal toolbar

     * (track width, via sizes, clearance ...

     */

    void AuxiliaryToolBar_Update_UI( );



    /**

     * Function AuxiliaryToolBar_DesignRules_Update_UI

     * update the displayed values: track width, via sizes, clearance

     * used when a ne netclass is selected

     */

    void AuxiliaryToolBar_DesignRules_Update_UI( );



    /* mouse functions events: */

    void             OnLeftClick( wxDC* DC, const wxPoint& MousePos );

    void             OnLeftDClick( wxDC* DC, const wxPoint& MousePos );