Minot fixes: Minor coding style issues fix (tab -> spaces). Add missing...

Minot fixes: Minor coding style issues fix (tab -> spaces). Add missing GetClass to all classes derived from EDA_ITEM. Make debug method Show() only compiled in debug mode.

3d-viewer/3d_material.h

@@ -65,6 +65,14 @@ public:
 #if defined(DEBUG)
     void Show( int nestLevel, std::ostream& os ) const { ShowDummy( os ); } // override
 #endif
+
+    /** Get class name
+     * @return  string "S3D_MATERIAL"
+     */
+    virtual wxString GetClass() const
+    {
+        return wxT( "S3D_MATERIAL" );
+    }
 };
 
 void SetOpenGlDefaultMaterial();

3d-viewer/3d_struct.h

@@ -176,6 +176,14 @@ public:
         return m_Shape3DName;
     }
 
+    /** Get class name
+     * @return  string "S3D_MASTER"
+     */
+    virtual wxString GetClass() const
+    {
+        return wxT( "S3D_MASTER" );
+    }
+
     /**
      * Function GetShape3DFullFilename
      * @return the full filename of the 3D shape,

eeschema/dialogs/dialog_print_using_printer.cpp

@@ -60,7 +60,7 @@ private:
     void OnPageSetup( wxCommandEvent& event );
     void OnPrintPreview( wxCommandEvent& event );
     void OnPrintButtonClick( wxCommandEvent& event );
-    void OnButtonCancelClick( wxCommandEvent& event ){ Close(); }
+    void OnButtonCancelClick( wxCommandEvent& event ) { Close(); }
 
     void GetPrintOptions();
 };

include/base_struct.h

@@ -386,10 +386,7 @@ public:
      * returns the class name.
      * @return wxString
      */
-    virtual wxString GetClass() const
-    {
-        return wxT( "EDA_ITEM" );
-    }
+    virtual wxString GetClass() const = 0;
 
     /**
      * Function GetSelectMenuText

include/worksheet_viewitem.h

@@ -123,10 +123,20 @@ public:
     /// @copydoc VIEW_ITEM::ViewGetLayers()
     void ViewGetLayers( int aLayers[], int& aCount ) const;
 
+#if defined(DEBUG)
     /// @copydoc EDA_ITEM::Show()
     void Show( int x, std::ostream& st ) const
     {
     }
+#endif
+
+    /** Get class name
+     * @return  string "WORKSHEET_VIEWITEM"
+     */
+    virtual wxString GetClass() const
+    {
+        return wxT( "WORKSHEET_VIEWITEM" );
+    }
 
 protected:
     /// File name displayed in the title block

pagelayout_editor/pl_editor_undo_redo.cpp

@@ -57,6 +57,14 @@ public:
 #if defined(DEBUG)
     virtual void Show( int nestLevel, std::ostream& os ) const {}
 #endif
+
+    /** Get class name
+     * @return  string "PL_ITEM_LAYOUT"
+     */
+    virtual wxString GetClass() const
+    {
+        return wxT( "PL_ITEM_LAYOUT" );
+    }
 };
 
 void PL_EDITOR_FRAME::SaveCopyInUndoList()

pcbnew/class_marker_pcb.h

@@ -124,6 +124,14 @@ public:
     void Show( int nestLevel, std::ostream& os ) const { ShowDummy( os ); } // override
 #endif
 
+    /** Get class name
+     * @return  string "MARKER_PCB"
+     */
+    virtual wxString GetClass() const
+    {
+        return wxT( "MARKER_PCB" );
+    }
+
 protected:
     ///> Pointer to BOARD_ITEM that causes DRC error.
     const BOARD_ITEM* m_item;

pcbnew/ratsnest_viewitem.h

@@ -52,10 +52,20 @@ public:
     /// @copydoc VIEW_ITEM::ViewGetLayers()
     void ViewGetLayers( int aLayers[], int& aCount ) const;
 
+#if defined(DEBUG)
     /// @copydoc EDA_ITEM::Show()
     void Show( int x, std::ostream& st ) const
     {
     }
+#endif
+
+    /** Get class name
+     * @return  string "RATSNEST_VIEWITEM"
+     */
+    virtual wxString GetClass() const
+    {
+        return wxT( "RATSNEST_VIEWITEM" );
+    }
 
 protected:
     ///> Object containing ratsnest data.

pcbnew/router/router_preview_item.h

@@ -72,7 +72,17 @@ public:
         m_clearance = aClearance;
     }
 
+#if defined(DEBUG)
     void Show( int aA, std::ostream& aB ) const {};
+#endif
+
+    /** Get class name
+     * @return  string "ROUTER_PREVIEW_ITEM"
+     */
+    virtual wxString GetClass() const
+    {
+        return wxT( "ROUTER_PREVIEW_ITEM" );
+    }
 
     const BOX2I ViewBBox() const;
 

pcbnew/tools/bright_box.h

@@ -55,9 +55,19 @@ public:
         aCount = 1;
     }
 
+#if defined(DEBUG)
     void Show( int x, std::ostream& st ) const
     {
     }
+#endif
+
+    /** Get class name
+     * @return  string "BRIGHT_BOX"
+     */
+    virtual wxString GetClass() const
+    {
+        return wxT( "BRIGHT_BOX" );
+    }
 
 private:
     static const KIGFX::COLOR4D BOX_COLOR;

pcbnew/tools/edit_points.h

@@ -503,9 +503,19 @@ public:
         aLayers[0] = ITEM_GAL_LAYER( GP_OVERLAY );
     }
 
+#if defined(DEBUG)
     void Show( int x, std::ostream& st ) const
     {
     }
+#endif
+
+    /** Get class name
+     * @return  string "EDIT_POINTS"
+     */
+    virtual wxString GetClass() const
+    {
+        return wxT( "EDIT_POINTS" );
+    }
 
 private:
     EDA_ITEM* m_parent;                 ///< Parent of the EDIT_POINTs

pcbnew/tools/selection_area.h

@@ -63,9 +63,19 @@ public:
         m_end = aEnd;
     }
 
+#if defined(DEBUG)
     void Show( int x, std::ostream& st ) const
     {
     }
+#endif
+
+    /** Get class name
+     * @return  string "SELECTION_AREA"
+     */
+    virtual wxString GetClass() const
+    {
+        return wxT( "SELECTION_AREA" );
+    }
 
 private:
     VECTOR2I m_origin, m_end;