Commit c333da19 authored by charras's avatar charras
Browse files

some "todo" cleanup

parent 0d3fc601

common/base_screen.cpp

+2 −1
Original line number Diff line number Diff line
@@ -9,6 +9,7 @@ 
#include "fctsys.h"

#include "common.h"



#include "sch_item_struct.h"



/* Implement wxSize array for grid list implementation. */

#include <wx/arrimpl.cpp>
@@ -498,7 +499,7 @@ EDA_BaseStruct* BASE_SCREEN::GetItemFromRedoList() 
 */

void BASE_SCREEN::Show( int nestLevel, std::ostream& os )

{

    EDA_BaseStruct* item = (EDA_BaseStruct*) EEDrawList;    // @todo : use SCH_ITEM as type for item

    SCH_ITEM* item = EEDrawList;



    // for now, make it look like XML, expand on this later.

    NestedSpace( nestLevel, os ) << '<' << GetClass().Lower().mb_str() <<

common/drawpanel.cpp

+0 −5
Original line number Diff line number Diff line
@@ -1188,11 +1188,6 @@ void WinEDA_DrawPanel::OnMouseEvent( wxMouseEvent& event ) 
#endif



    LastPanel = this;



    /* @todo: move this to where it is really needed, obviously not here in

     * response to every mouse move event:

     * m_Parent->SetToolbars();

     */

}

demos/pic_programmer/pic_programmer.brd

+5925 −28413

File changed.

File size exceeds preview limit.

View original file
View changed file

eeschema/plot.cpp

+2 −6
Original line number Diff line number Diff line
@@ -285,9 +285,7 @@ void PlotLibPart( SCH_COMPONENT* DrawLibItem ) 
            {

                LibDrawPin* Pin = (LibDrawPin*) DEntry;

                if( Pin->m_Attributs & PINNOTDRAW )

                {

                        break;

                }



                /* Calcul de l'orientation reelle de la Pin */

                orient = Pin->ReturnPinDrawOrient( TransMat );
@@ -295,9 +293,8 @@ void PlotLibPart( SCH_COMPONENT* DrawLibItem ) 
                pos = TransformCoordinate( TransMat, Pin->m_Pos ) + DrawLibItem->m_Pos;



                /* Dessin de la pin et du symbole special associe */

                SetCurrentLineWidth( -1 );

                PlotPinSymbol( pos, Pin->m_PinLen, orient, Pin->m_PinShape );

                int thickness = 0;   // @todo: calcultae the pen tickness

                int thickness = MAX( g_PlotLine_Width, g_DrawMinimunLineWidth );;

                Pin->PlotPinTexts( pos, orient,

                                   Entry->m_TextInside,

                                   Entry->m_DrawPinNum, Entry->m_DrawPinName,
@@ -471,7 +468,6 @@ static void PlotTextField( SCH_COMPONENT* DrawLibItem, 
		thickness = MAX( g_PlotLine_Width, g_DrawMinimunLineWidth );

    SetCurrentLineWidth( thickness );



    //@todo not sure what to do here in terms of plotting components that may have multiple REFERENCE entries.

    if( !IsMulti || (FieldNumber != REFERENCE) )

    {

        PlotGraphicText( g_PlotFormat, textpos, color, field->m_Text,

eeschema/schframe.cpp

+2 −16
Original line number Diff line number Diff line
@@ -245,28 +245,14 @@ void WinEDA_SchematicFrame::SetSheetNumberAndCount() 
}





/***************************************************/

SCH_SCREEN* WinEDA_SchematicFrame::GetScreen() const

/***************************************************/

{

    return m_CurrentSheet->LastScreen();

}





void WinEDA_SchematicFrame::SetScreen( SCH_SCREEN* screen )

{

    //find it in the hierarchy, and set it.

    //there is ambiguity in this function (there may be several

    //instances of a given sheet, but irregardless it is useful

    //for printing etc.

    DrawSheetPath sheetlist;



    if( g_RootSheet->LocatePathOfScreen( screen, &sheetlist ) )

    {

        *m_CurrentSheet = sheetlist;

        m_CurrentSheet->UpdateAllScreenReferences();

    }

}





wxString WinEDA_SchematicFrame::GetScreenDesc()

{

    wxString s = m_CurrentSheet->PathHumanReadable();