Commit a32b974f authored by jean-pierre charras's avatar jean-pierre charras

Pcbnew: fix bug in D_PAD ctor: m_LengthDie not initialized. Disable...

Pcbnew: fix bug in D_PAD ctor: m_LengthDie not initialized. Disable m_LengthDie read from .brd files,
because this bug breaks compatibility with older version of Pcbnew , and the stored value as most of time no sense.
To enable m_LengthDie reading, see class_pad.cpp
parent c50efb48
...@@ -14,6 +14,11 @@ ...@@ -14,6 +14,11 @@
#include "class_board_design_settings.h" #include "class_board_design_settings.h"
#include "richio.h" #include "richio.h"
// Due to a bug in previous versions ( m_LengthDie not initialized in D_PAD ctor)
// m_LengthDie is no more read from .brd files
// Uncomment this next line to read m_LengthDie from .brd files
// #define READ_PAD_LENGTH_DIE
int D_PAD::m_PadSketchModePenSize = 0; // Pen size used to draw pads in sketch mode int D_PAD::m_PadSketchModePenSize = 0; // Pen size used to draw pads in sketch mode
...@@ -23,6 +28,7 @@ D_PAD::D_PAD( MODULE* parent ) : BOARD_CONNECTED_ITEM( parent, TYPE_PAD ) ...@@ -23,6 +28,7 @@ D_PAD::D_PAD( MODULE* parent ) : BOARD_CONNECTED_ITEM( parent, TYPE_PAD )
m_Size.x = m_Size.y = 500; // give it a reasonable size m_Size.x = m_Size.y = 500; // give it a reasonable size
m_Orient = 0; // Pad rotation in 1/10 degrees m_Orient = 0; // Pad rotation in 1/10 degrees
m_LengthDie = 0;
if( m_Parent && (m_Parent->Type() == TYPE_MODULE) ) if( m_Parent && (m_Parent->Type() == TYPE_MODULE) )
{ {
...@@ -477,9 +483,11 @@ int D_PAD::ReadDescr( LINE_READER* aReader ) ...@@ -477,9 +483,11 @@ int D_PAD::ReadDescr( LINE_READER* aReader )
break; break;
case 'L': case 'L':
#ifdef READ_PAD_LENGTH_DIE
int lengthdie; int lengthdie;
nn = sscanf( PtLine, "%d", &lengthdie ); nn = sscanf( PtLine, "%d", &lengthdie );
m_LengthDie = lengthdie; m_LengthDie = lengthdie;
#endif
break; break;
case '.': /* Read specific data */ case '.': /* Read specific data */
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment