Commit 43167593 authored by Dick Hollenbeck's avatar Dick Hollenbeck
Browse files

remove global g_UserLibDirBuffer which was a project specific global, and no... 

remove global g_UserLibDirBuffer which was a project specific global, and no longer used with FP_LIB_TABLE support.
parent 093f810d

CMakeLists.txt

+1 −0
Original line number Diff line number Diff line
@@ -212,6 +212,7 @@ if( CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang" ) 


            # Defeat ELF's ability to use the GOT to replace locally implemented functions

            # with ones from another module.

            # https://bugs.launchpad.net/kicad/+bug/1322354

            set( CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} ${TO_LINKER},-Bsymbolic" )

            set( CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} ${TO_LINKER},-Bsymbolic" )

        endif()

TODO.txt

+3 −1
Original line number Diff line number Diff line
@@ -69,4 +69,6 @@ Dick's Final TODO List: 
    https://blueprints.launchpad.net/kicad/+spec/modular-kicad



    Issues as a result of minimal testing:

        Kicad project manager will crash when requesting help file.
 
        If eeschema launched from C++ project manager does not find all libraries,

        then the dialog showing the names of missing libraries is not visible,

        probably because the wxFrame parent is not yet visible.

common/common.cpp

+0 −1
Original line number Diff line number Diff line
@@ -59,7 +59,6 @@ 
 */



bool           g_ShowPageLimits = true;

wxString       g_UserLibDirBuffer;



EDA_UNITS_T    g_UserUnit;

EDA_COLOR_T    g_GhostColor;

cvpcb/CMakeLists.txt

+0 −5
Original line number Diff line number Diff line
@@ -21,11 +21,6 @@ include_directories( 




set( CVPCB_DIALOGS



    # These 2 still use search paths, which don't exist in footprint land.

#    dialogs/dialog_cvpcb_config.cpp

#    dialogs/dialog_cvpcb_config_fbp.cpp



    dialogs/dialog_display_options.cpp

    dialogs/dialog_display_options_base.cpp

    ../pcbnew/dialogs/dialog_fp_lib_table.cpp

cvpcb/cfg.cpp

+1 −7
Original line number Diff line number Diff line
@@ -49,18 +49,12 @@ PARAM_CFG_ARRAY& CVPCB_MAINFRAME::GetProjectFileParameters() 


    m_projectFileParams.push_back( new PARAM_CFG_BASE( GROUP_PCB_LIBS, PARAM_COMMAND_ERASE ) );



    m_projectFileParams.push_back( new PARAM_CFG_LIBNAME_LIST(

        wxT( "LibName" ), &m_ModuleLibNames, GROUP_PCB_LIBS ) );



    m_projectFileParams.push_back( new PARAM_CFG_LIBNAME_LIST(

        wxT( "EquName" ), &m_AliasLibNames, GROUP_CVP_EQU ) );



    m_projectFileParams.push_back( new PARAM_CFG_WXSTRING(

        wxT( "NetIExt" ), &m_NetlistFileExtension ) );



    m_projectFileParams.push_back( new PARAM_CFG_FILENAME(

        wxT( "LibDir" ), &m_UserLibraryPath, GROUP_PCB_LIBS ) );



    return m_projectFileParams;

}
@@ -81,7 +75,7 @@ void CVPCB_MAINFRAME::LoadProjectFile( const wxString& aFileName ) 
    if( m_NetlistFileExtension.IsEmpty() )

        m_NetlistFileExtension = wxT( "net" );



    // Force it to be loaded on demand.

    // Force FP_LIB_TABLE to be loaded on demand.

    prj.ElemClear( PROJECT::ELEM_FPTBL );

}