track & via recovery stuff

change_log.txt

@@ -4,6 +4,19 @@ Started 2007-June-11
 Please add newer entries at the top, list the date and your name with 
 email address.
 
+2007-Oct-19 UPDATE   Dick Hollenbeck <dick@softplc.com>
+================================================================================
++ pcbnew
+  * "Clean tracks" changed to "Track operations".
+  * Housekeeping on clean.cpp completed.
+    Added static void ConnectDanglingEndToVia( BOARD* pcb ) in clean.cpp which
+    extends tracks to via centers.  Call it from "extend to pads", works nice.
+  * Added tooltip text to cleaningoptions_dialog.cpp's m_ConnectToPadsOpt
+    but don't know if DialogBlocks will parse this backwards.
+  * Made compilable, somebody broke #define VIA_???? s throughout.  Would not compile. 
+  * SEGVIA::SetPos() & GetPos() added.
+
+  
 2007-Oct-17 UPDATE  Jean-Pierre Charras <jean-pierre.charras@inpg.fr>
 ================================================================================
 + pcbnew:
@@ -13,8 +26,6 @@ email address.
 	I must work on algos.
 
 
-
-
 2007-Oct-17 UPDATE   Geoff Harland <gharlandau@yahoo.com.au>
 ================================================================================
 + pcbnew

pcbnew/class_track.h

@@ -244,6 +244,9 @@ public:
     void    SetLayerPair( int top_layer, int bottom_layer );
     void    ReturnLayerPair( int* top_layer, int* bottom_layer ) const;
 
+    const wxPoint& GetPos() const { return m_Start; }
+    void  SetPos( const wxPoint& aPoint ) { m_Start=aPoint;  m_End=aPoint; } 
+    
     /**
      * Function GetClass
      * returns the class name.

pcbnew/cleaningoptions_dialog.cpp

@@ -160,6 +160,7 @@ void WinEDA_CleaningOptionsFrame::CreateControls()
     itemStaticBoxSizer4->Add(m_DeleteunconnectedOpt, 0, wxALIGN_LEFT|wxALL, 5);
 
     m_ConnectToPadsOpt = new wxCheckBox( itemDialog1, ID_CHECKBOX, _("Connect to Pads"), wxDefaultPosition, wxDefaultSize, 0 );
+    m_ConnectToPadsOpt->SetToolTip( _("Extend dangling tracks which partially cover a pad or via, all the way to pad or via center") );
     m_ConnectToPadsOpt->SetValue(false);
     itemStaticBoxSizer4->Add(m_ConnectToPadsOpt, 0, wxALIGN_LEFT|wxALL, 5);
 

pcbnew/locate.cpp

@@ -262,11 +262,10 @@ D_PAD* Locate_Pad_Connecte( BOARD* Pcb, TRACK* ptr_piste, int extr )
  */
 {
     D_PAD*  ptr_pad = NULL;
-    int     masque_layer;
-    MODULE* module;
     wxPoint ref_pos;
 
-    masque_layer = g_TabOneLayerMask[ptr_piste->GetLayer()];
+    int     masque_layer = g_TabOneLayerMask[ptr_piste->GetLayer()];
+    
     if( extr == START )
     {
         ref_pos = ptr_piste->m_Start;
@@ -275,8 +274,8 @@ D_PAD* Locate_Pad_Connecte( BOARD* Pcb, TRACK* ptr_piste, int extr )
     {
         ref_pos = ptr_piste->m_End;
     }
-    module = Pcb->m_Modules;
-    for( ; module != NULL; module = (MODULE*) module->Pnext )
+    
+    for( MODULE* module = Pcb->m_Modules;  module;  module = module->Next() )
     {
         ptr_pad = Locate_Pads( module, ref_pos, masque_layer );
         if( ptr_pad != NULL )
@@ -421,13 +420,12 @@ D_PAD* Locate_Any_Pad( BOARD* Pcb, int typeloc, bool OnlyCurrentLayer )
 
 D_PAD* Locate_Any_Pad( BOARD* Pcb, const wxPoint& ref_pos, bool OnlyCurrentLayer )
 {
-    D_PAD*  pt_pad;
-    MODULE* module;
     int     layer_mask = g_TabOneLayerMask[ ( (PCB_SCREEN*) ActiveScreen )->m_Active_Layer];
 
-    module = Pcb->m_Modules;
-    for( ; module != NULL; module = (MODULE*) module->Pnext )
+    for( MODULE* module=Pcb->m_Modules;  module;   module = module->Next() )
     {
+        D_PAD*  pt_pad;
+        
         /* First: Search a pad on the active layer: */
         if( ( pt_pad = Locate_Pads( module, ref_pos, layer_mask ) ) != NULL )
             return pt_pad;
@@ -468,8 +466,7 @@ D_PAD* Locate_Pads( MODULE* module, int masque_layer, int typeloc )
 
 D_PAD* Locate_Pads( MODULE* module, const wxPoint& ref_pos, int masque_layer )
 {
-    D_PAD*  pt_pad = module->m_Pads;
-    for( ; pt_pad != NULL; pt_pad = (D_PAD*) pt_pad->Pnext )
+    for( D_PAD* pt_pad = module->m_Pads;   pt_pad;   pt_pad = pt_pad->Next() )
     {
         /* ... et sur la bonne couche */
         if( (pt_pad->m_Masque_Layer & masque_layer) == 0 )

pcbnew/menubarpcb.cpp

@@ -251,8 +251,8 @@ wxMenuBar * menuBar = GetMenuBar();
 	    item->SetBitmap(tools_xpm);
 		miscellaneous_menu->Append(item);
 
-		item = new wxMenuItem(miscellaneous_menu, ID_MENU_PCB_CLEAN, _("&Clean tracks"),
-				_("Clean stubs, vias, delete break points"));
+		item = new wxMenuItem(miscellaneous_menu, ID_MENU_PCB_CLEAN, _("&Track operations"),
+				_("Clean stubs, vias, delete break points, or connect dangling tracks to pads and vias"));
 	    item->SetBitmap(delete_body_xpm);
 		miscellaneous_menu->Append(item);
 

todo.txt

@@ -72,4 +72,7 @@ others (what are they?):
 :
 :
 
+*** Add tooltip text to cleaningoptions_dialog.cpp throughout for all options.
+Might need to do this using DialogBlocks.
+