warnings

cvpcb/class_footprints_listbox.cpp

@@ -60,11 +60,13 @@ int FOOTPRINTS_LISTBOX::GetCount()
 
 void FOOTPRINTS_LISTBOX::SetString( unsigned linecount, const wxString& text )
 {
-    if( linecount >= m_footprintList.Count() )
-        linecount = m_footprintList.Count() - 1;
-
-    if( linecount >= 0 )
+    unsigned count = m_footprintList.Count();
+    if( count > 0 )
+    {
+        if( linecount >= count )
+            linecount = count - 1;
         m_footprintList[linecount] = text;
+    }
 }
 
 

cvpcb/class_library_listbox.cpp

@@ -60,11 +60,13 @@ int LIBRARY_LISTBOX::GetCount()
 
 void LIBRARY_LISTBOX::SetString( unsigned linecount, const wxString& text )
 {
-    if( linecount >= m_libraryList.Count() )
-        linecount = m_libraryList.Count() - 1;
-
-    if( linecount >= 0 )
+    unsigned count = m_libraryList.Count();
+    if( count > 0 )
+    {
+        if( linecount >= count )
+            linecount = count - 1;
         m_libraryList[linecount] = text;
+    }
 }
 
 

pcb_calculator/datafile_read_write.h

 #ifndef DATAFILE_READ_WRITE_H_
-#define PDATAFILE_READ_WRITE_H_
+#define DATAFILE_READ_WRITE_H_
 /*
  * This program source code file is part of KiCad, a free EDA CAD application.
  *

pcbnew/modview_frame.cpp

@@ -713,8 +713,8 @@ void FOOTPRINT_VIEWER_FRAME::OnIterateFootprintList( wxCommandEvent& event )
         break;
 
     default:
-        wxFAIL_MSG( wxT( "FOOTPRINT_VIEWER_FRAME::OnIterateFootprintList error: id = " ) +
-                    event.GetId() );
+        wxString id = wxString::Format(wxT("%i"),event.GetId());
+        wxFAIL_MSG( wxT( "FOOTPRINT_VIEWER_FRAME::OnIterateFootprintList error: id = " ) + id );
     }
 }